bpo-31418: Fix an assertion failure in case of an exception with a bad __module__ attribute #3539
Conversation
|
feel free to remove the NEWS.d item if you don't think it is necessary. |
| @@ -0,0 +1,2 @@ | |||
| Fix an assertion failure in case of an exception with a bad ``__module__`` | |||
There was a problem hiding this comment.
"in PyErr_WriteUnraisable()"
| @@ -1,2 +1,2 @@ | |||
| Fix an assertion failure in case of an exception with a bad ``__module__`` | |||
| attribute. Patch by Oren Milman. | |||
| Fix an assertion failure in `c.PyErr_WriteUnraisable()` in case of an | |||
There was a problem hiding this comment.
What is c.PyErr_WriteUnraisable()?
There was a problem hiding this comment.
https://devguide.python.org/committing/#what-s-new-and-news-entries says:
(single backticks) in reST can be used to refer to objects in the documentation.
I thought this means that i should specify (inside single backticks) an object in the docs, according to how it appears in the docs (i.e. when pressing the Permalink to this definition button - https://docs.python.org/3.7/c-api/exceptions.html#c.PyErr_WriteUnraisable).
so it should just be PyErr_WriteUnraisable()?
There was a problem hiding this comment.
Yes, it should be without "c." prefix.
|
sorry for the trouble, and thanks for your patience, Serhiy |
serhiy-storchaka
added
needs backport to 3.6
type-bug
|
Thanks @orenmn for the PR, and @serhiy-storchaka for merging it 🌮🎉.. I'm working now to backport this PR to: 3.6. |
…in case of an exception with a bad __module__ attribute. (pythonGH-3539) (cherry picked from commit f6e61df)
|
GH-3556 is a backport of this pull request to the 3.6 branch. |
https://bugs.python.org/issue31418