Skip to content

bpo-43916: Use Py_TPFLAGS_DISABLE_NEW flag in hashlib #25722

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 3 commits into from
Closed

bpo-43916: Use Py_TPFLAGS_DISABLE_NEW flag in hashlib #25722

wants to merge 3 commits into from

Conversation

tiran
Copy link
Member

@tiran tiran commented Apr 29, 2021 •
edited by bedevere-bot
Loading

vstinner and others added 3 commits April 29, 2021 17:36
@vstinner
bpo-43916: Add Py_TPFLAGS_DISABLE_NEW type flag
b474009 
Add a new Py_TPFLAGS_DISABLE_NEW type flag to disallow creating
instances of a type.
@vstinner
MyStr_Type example uses Py_TPFLAGS_DISABLE_NEW
55355ab
@tiran
bpo-43916: Use Py_TPFLAGS_DISABLE_NEW flag in hashlib
499b1c6 
Signed-off-by: Christian Heimes <[email protected]>
@tiran tiran mentioned this pull request Apr 29, 2021
Merged
@vstinner
Copy link
Member

I merged my PR #25721 and the flag was renamed. Can you please rebase your PR?

vstinner
vstinner approved these changes Apr 30, 2021
View reviewed changes
Copy link
Member

@vstinner vstinner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. If you rebase your PR and rename Py_TPFLAGS_DISABLE_NEW flag to Py_TPFLAGS_DISALLOW_INSTANTIATION.

I only reviewed Lib/test/test_hashlib.py and Modules/_hashopenssl.c changes.

@vstinner
Copy link
Member

I created PR #25745 which also updates the posix module.

@tiran
Copy link
Member Author

tiran commented Apr 30, 2021

Thanks Victor!

@tiran tiran closed this Apr 30, 2021
@vstinner vstinner mentioned this pull request Apr 30, 2021
Merged
@pablogsal pablogsal mentioned this pull request May 18, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vstinner vstinner vstinner approved these changes

Assignees
No one assigned
Labels
awaiting merge skip news
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@tiran @vstinner @the-knights-who-say-ni @bedevere-bot