Skip to content

bpo-43916: Remove _disabled_new() function #25745

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Apr 30, 2021
Merged

bpo-43916: Remove _disabled_new() function #25745

merged 2 commits into from
Apr 30, 2021

Conversation

vstinner
Copy link
Member

@vstinner vstinner commented Apr 30, 2021 •
edited by bedevere-bot
Loading

Use the new Py_TPFLAGS_DISALLOW_INSTANTIATION flag on posix and
_hashlib types.

https://bugs.python.org/issue43916

@vstinner
bpo-43916: Remove _disabled_new() function
7c5d116 
Use the new Py_TPFLAGS_DISALLOW_INSTANTIATION flag on posix and
_hashlib types.
@vstinner vstinner requested a review from tiran as a code owner April 30, 2021 11:02
@vstinner vstinner mentioned this pull request Apr 30, 2021
Closed
@vstinner
Copy link
Member Author

cc @tiran @erlend-aasland

erlend-aasland
erlend-aasland requested changes Apr 30, 2021
View reviewed changes
Copy link
Contributor

@erlend-aasland erlend-aasland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You need to update Lib/test/test_hmac.py too

@vstinner
Copy link
Member Author

You need to update Lib/test/test_hmac.py too

Oops, I missed that part in @tiran's PR #25722.

@vstinner
Copy link
Member Author

  • Windows x86: test_asyncio failed (unrelated).
  • Tests / Ubuntu SSL tests with OpenSSL 1.1.1k: test_asyncio failed (unrelated).
  • Tests / Ubuntu SSL tests with OpenSSL 3.0.0-alpha15: test_asyncio failed (unrelated).

@vstinner vstinner merged commit 0cad068 into python:master Apr 30, 2021
@vstinner vstinner deleted the remove_disabled_new branch April 30, 2021 12:06
@pablogsal pablogsal mentioned this pull request May 18, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@erlend-aasland erlend-aasland erlend-aasland requested changes

@tiran tiran tiran approved these changes

Assignees
No one assigned
Labels
skip news
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@vstinner @tiran @erlend-aasland @the-knights-who-say-ni @bedevere-bot