bpo-41515: Fix KeyError raised in get_type_hints #25352
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
typing.get_type_hints raises KeyError on synthetic modules that don't appear in sys.modules.
Fidget-Spinner
approved these changes
Apr 12, 2021
Member
Fidget-Spinner
left a comment
Fidget-Spinner
left a comment
There was a problem hiding this comment.
Thanks for doing this! I've been eyeing this issue for a while now and I agree with what you said on bpo about more errors with annotations becoming the default. Hopefully with this fix, the transition to 3.10 will be smoother :).
Misc/NEWS.d/next/Library/2021-04-12-06-01-10.bpo-41515.YaVReb.rst
Outdated
Show resolved
Hide resolved
gvanrossum
approved these changes
Apr 12, 2021
Co-authored-by: Ken Jin <[email protected]>
Member
|
Thanks! I'll merge when tests pass. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
typing.get_type_hints raises KeyError on synthetic modules that don't appear in sys.modules.
https://bugs.python.org/issue41515