Skip to content

bpo-41515: prevent get_type_hints from raising KeyError #21816

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from
Closed

bpo-41515: prevent get_type_hints from raising KeyError #21816

wants to merge 2 commits into from

Conversation

efahl
Copy link
Contributor

@efahl efahl commented Aug 10, 2020

efahl added 2 commits August 10, 2020 12:26
typing.get_type_hints raises KeyError on synthetic modules that don't appear in sys.modules.
@the-knights-who-say-ni
Copy link

Hello, and thanks for your contribution!

I'm a bot set up to make sure that the project can legally accept this contribution by verifying everyone involved has signed the PSF contributor agreement (CLA).

Recognized GitHub username

We couldn't find a bugs.python.org (b.p.o) account corresponding to the following GitHub usernames:

@efahl

This might be simply due to a missing "GitHub Name" entry in one's b.p.o account settings. This is necessary for legal reasons before we can look at this contribution. Please follow the steps outlined in the CPython devguide to rectify this issue.

You can check yourself to see if the CLA has been received.

Thanks again for the contribution, we look forward to reviewing it!

Copy link
Member

@gvanrossum gvanrossum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for sitting on this so long. Can you prepare a short blurb too?

@gvanrossum
Copy link
Member

Also please rebase, it might fix the macOS test failure.

@tirkarthi
Copy link
Member

I have created #25352 with attribution to author since I don't have permission to update the PR. Thanks.

@gvanrossum
Copy link
Member

Closed in favor of GH-25352.

@gvanrossum gvanrossum closed this Apr 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants