bpo-37616: Enhance calculate_zip_path() #20225
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use sprintf() to format the filename, rather than accessing directly characters of the VERSION string. Make getpath.c ready for Python version 3.100 or version 10.0.
|
@pablogsal proposed PR #20214. |
|
This solution is great but lacks preprocessor magic 😆 |
pablogsal
reviewed
May 19, 2020
| @@ -1296,16 +1296,28 @@ calculate_zip_path(PyCalculatePath *calculate) | |||
| { | |||
| PyStatus res; | |||
|
|
|||
| // wsprintf() is not available on all platforms: | |||
There was a problem hiding this comment.
I honestly find this code harder to follow and more complex than the preprocessor solution
|
@pablogsal's PR #20214 is way simpler (and wa merged). I close my PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use sprintf() to format the filename, rather than accessing directly
characters of the VERSION string.
Make getpath.c ready for Python version 3.100 or version 10.0.
https://bugs.python.org/issue37616