-
-
Notifications
You must be signed in to change notification settings - Fork 31.9k
bpo-37616: Handle version info more gracefully in getpath.c #20214
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
From the C99 standard:
|
@serhiy-storchaka Does it occur to you if there is a simpler way to produce this string at compile time? |
Co-authored-by: Victor Stinner <[email protected]>
Co-authored-by: Victor Stinner <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
If this change breaks IRIX support, we can reconsider IRIX support later ;-)
🤖 New build scheduled with the buildbot fleet by @pablogsal for commit 4211927 🤖 If you want to schedule another build, you need to add the ":hammer: test-with-buildbots" label again. |
Seems that the almost all buildbot workers are green and the ones that fail are because some other unrelated issues (no space left on device and some PGO/LTO failures elsewhere). So I am going ahead and merge this |
CC: @ambv |
Thanks @pablogsal for the PR 🌮🎉.. I'm working now to backport this PR to: 3.9. |
Sorry, @pablogsal, I could not cleanly backport this to |
@pablogsal: I don't think that we need a backport to 3.9 which only uses a single digit for the minor version. |
Makes sense, I just wanted to extend the progress 😅 |
https://bugs.python.org/issue37616