Skip to content

bpo-38275: Fix test_ssl issue caused by GH-16386 #16428

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 26, 2019

Conversation

tiran
Copy link
Member

@tiran tiran commented Sep 26, 2019

Check presence of SSLContext.minimum_version to make tests pass with
old versions of OpenSSL.

Signed-off-by: Christian Heimes [email protected]

https://bugs.python.org/issue38275

Check presence of SSLContext.minimum_version to make tests pass with
old versions of OpenSSL.

Signed-off-by: Christian Heimes <[email protected]>
@vstinner
Copy link
Member

vstinner commented Sep 26, 2019

bpo-38275: Fix for GH-16386 #16428

Please mention at least test_ssl in the commit title when you merge this PR.

@tiran tiran changed the title bpo-38275: Fix for GH-16386 bpo-38275: Fix test_ssl issue caused by GH-16386 Sep 26, 2019
@tiran tiran merged commit 9f77268 into python:master Sep 26, 2019
@tiran tiran deleted the bpo-38275-fixup branch September 26, 2019 16:23
@miss-islington
Copy link
Contributor

Thanks @tiran for the PR 🌮🎉.. I'm working now to backport this PR to: 3.7, 3.8.
🐍🍒⛏🤖

@bedevere-bot
Copy link

@tiran: Please replace # with GH- in the commit message next time. Thanks!

@miss-islington
Copy link
Contributor

Sorry, @tiran, I could not cleanly backport this to 3.8 due to a conflict.
Please backport using cherry_picker on command line.
cherry_picker 9f77268f901cc3e8874e5042361520a0e482476a 3.8

@miss-islington
Copy link
Contributor

Sorry @tiran, I had trouble checking out the 3.7 backport branch.
Please backport using cherry_picker on command line.
cherry_picker 9f77268f901cc3e8874e5042361520a0e482476a 3.7

jacobneiltaylor pushed a commit to jacobneiltaylor/cpython that referenced this pull request Dec 5, 2019
Check presence of SSLContext.minimum_version to make tests pass with
old versions of OpenSSL.

Signed-off-by: Christian Heimes <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
skip news tests Tests in the Lib/test dir
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants