Skip to content

[3.7] bpo-38275: Skip ssl tests for disabled versions (GH-16427) #16427

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Sep 26, 2019

Conversation

tiran
Copy link
Member

@tiran tiran commented Sep 26, 2019

test_ssl now handles disabled TLS/SSL versions better. OpenSSL's crypto
policy and run-time settings are recognized and tests for disabled versions
are skipped.

Signed-off-by: Christian Heimes [email protected]

https://bugs.python.org/issue38275.
(cherry picked from commit df6ac7e)

Co-authored-by: Christian Heimes [email protected]

https://bugs.python.org/issue38275

test_ssl now handles disabled TLS/SSL versions better. OpenSSL's crypto
policy and run-time settings are recognized and tests for disabled versions
are skipped.

Signed-off-by: Christian Heimes <[email protected]>

https://bugs.python.org/issue38275.
(cherry picked from commit df6ac7e)

Co-authored-by: Christian Heimes <[email protected]>
@tiran
Copy link
Member Author

tiran commented Sep 26, 2019

PR needs fix from GH-16428

Check presence of SSLContext.minimum_version to make tests pass with
old versions of OpenSSL.

Signed-off-by: Christian Heimes <[email protected]>
@tiran
Copy link
Member Author

tiran commented Sep 26, 2019

I have cherry-picked commit 34992cf into this backport.

@tiran tiran changed the title [3.7] bpo-38275: Skip ssl tests for disabled versions (GH-16386) [3.7] bpo-38275: Skip ssl tests for disabled versions (GH-16427) Sep 26, 2019
@tiran tiran merged commit 2c24f2c into python:3.7 Sep 26, 2019
@tiran tiran deleted the backport-df6ac7e-3.7 branch September 26, 2019 20:54
@bedevere-bot
Copy link

⚠️⚠️⚠️ Buildbot failure ⚠️⚠️⚠️

Hi! The buildbot s390x Debian 3.7 has failed when building commit 2c24f2c.

What do you need to do:

  1. Don't panic.
  2. Check the buildbot page in the devguide if you don't know what the buildbots are or how they work.
  3. Go to the page of the buildbot that failed (https://buildbot.python.org/all/#builders/119/builds/1513) and take a look at the build logs.
  4. Check if the failure is related to this commit (2c24f2c) or if it is a false positive.
  5. If the failure is related to this commit, please, reflect that on the issue and make a new Pull Request with a fix.

You can take a look at the buildbot page here:

https://buildbot.python.org/all/#builders/119/builds/1513

Failed tests:

  • test_asyncio
  • test_pty
  • test_readline
  • test_os
  • test_openpty

Failed subtests:

  • test_fork - test.test_pty.PtyTest
  • test_read_pty_output - test.test_asyncio.test_events.EPollEventLoopTests
  • test_bidirectional_pty - test.test_asyncio.test_events.SelectEventLoopTests
  • test_bidirectional_pty - test.test_asyncio.test_events.PollEventLoopTests
  • test_auto_history_disabled - test.test_readline.TestReadline
  • test_write_pty - test.test_asyncio.test_events.PollEventLoopTests
  • test_history_size - test.test_readline.TestReadline
  • test_openpty - test.test_os.FDInheritanceTests
  • test_read_pty_output - test.test_asyncio.test_events.PollEventLoopTests
  • test_bidirectional_pty - test.test_asyncio.test_events.EPollEventLoopTests
  • test_nonascii - test.test_readline.TestReadline
  • test - test.test_openpty.OpenptyTest
  • test_write_pty - test.test_asyncio.test_events.EPollEventLoopTests
  • test_auto_history_enabled - test.test_readline.TestReadline
  • test_read_pty_output - test.test_asyncio.test_events.SelectEventLoopTests

Summary of the results of the build (if available):

== Tests result: FAILURE then FAILURE ==

398 tests OK.

10 slowest tests:

  • test_concurrent_futures: 2 min 18 sec
  • test_multiprocessing_spawn: 1 min 30 sec
  • test_multiprocessing_forkserver: 1 min 13 sec
  • test_multiprocessing_fork: 1 min 5 sec
  • test_tokenize: 1 min 3 sec
  • test_tools: 47 sec 545 ms
  • test_lib2to3: 42 sec 514 ms
  • test_io: 40 sec 105 ms
  • test_asyncio: 36 sec 560 ms
  • test_gdb: 36 sec 441 ms

5 tests failed:
test_asyncio test_openpty test_os test_pty test_readline

13 tests skipped:
test_devpoll test_ioctl test_kqueue test_msilib test_ossaudiodev
test_startfile test_tix test_tk test_ttk_guionly test_winconsoleio
test_winreg test_winsound test_zipfile64

5 re-run tests:
test_asyncio test_openpty test_os test_pty test_readline

Total duration: 11 min 23 sec

Click to see traceback logs
Traceback (most recent call last):
  File "/home/dje/cpython-buildarea/3.7.edelsohn-debian-z/build/Lib/test/test_readline.py", line 274, in test_history_size
    run_pty(script, input=b"last input\r", env=env)
  File "/home/dje/cpython-buildarea/3.7.edelsohn-debian-z/build/Lib/test/test_readline.py", line 285, in run_pty
    [master, slave] = pty.openpty()
  File "/home/dje/cpython-buildarea/3.7.edelsohn-debian-z/build/Lib/pty.py", line 29, in openpty
    master_fd, slave_name = _open_terminal()
  File "/home/dje/cpython-buildarea/3.7.edelsohn-debian-z/build/Lib/pty.py", line 59, in _open_terminal
    raise OSError('out of pty devices')
OSError: out of pty devices


Traceback (most recent call last):
  File "/home/dje/cpython-buildarea/3.7.edelsohn-debian-z/build/Lib/test/test_openpty.py", line 11, in test
    master, slave = os.openpty()
FileNotFoundError: [Errno 2] No such file or directory


Traceback (most recent call last):
  File "/home/dje/cpython-buildarea/3.7.edelsohn-debian-z/build/Lib/test/test_readline.py", line 153, in test_auto_history_disabled
    output = run_pty(self.auto_history_script.format(False))
  File "/home/dje/cpython-buildarea/3.7.edelsohn-debian-z/build/Lib/test/test_readline.py", line 285, in run_pty
    [master, slave] = pty.openpty()
  File "/home/dje/cpython-buildarea/3.7.edelsohn-debian-z/build/Lib/pty.py", line 29, in openpty
    master_fd, slave_name = _open_terminal()
  File "/home/dje/cpython-buildarea/3.7.edelsohn-debian-z/build/Lib/pty.py", line 59, in _open_terminal
    raise OSError('out of pty devices')
OSError: out of pty devices


Traceback (most recent call last):
  File "/home/dje/cpython-buildarea/3.7.edelsohn-debian-z/build/Lib/test/support/__init__.py", line 623, in wrapper
    return func(*args, **kw)
  File "/home/dje/cpython-buildarea/3.7.edelsohn-debian-z/build/Lib/test/test_asyncio/test_events.py", line 1645, in test_bidirectional_pty
    master, read_slave = os.openpty()
FileNotFoundError: [Errno 2] No such file or directory


Traceback (most recent call last):
  File "/home/dje/cpython-buildarea/3.7.edelsohn-debian-z/build/Lib/test/test_pty.py", line 130, in test_fork
    pid, master_fd = pty.fork()
  File "/home/dje/cpython-buildarea/3.7.edelsohn-debian-z/build/Lib/pty.py", line 96, in fork
    master_fd, slave_fd = openpty()
  File "/home/dje/cpython-buildarea/3.7.edelsohn-debian-z/build/Lib/pty.py", line 29, in openpty
    master_fd, slave_name = _open_terminal()
  File "/home/dje/cpython-buildarea/3.7.edelsohn-debian-z/build/Lib/pty.py", line 59, in _open_terminal
    raise OSError('out of pty devices')
OSError: out of pty devices


Traceback (most recent call last):
  File "/home/dje/cpython-buildarea/3.7.edelsohn-debian-z/build/Lib/test/test_readline.py", line 149, in test_auto_history_enabled
    output = run_pty(self.auto_history_script.format(True))
  File "/home/dje/cpython-buildarea/3.7.edelsohn-debian-z/build/Lib/test/test_readline.py", line 285, in run_pty
    [master, slave] = pty.openpty()
  File "/home/dje/cpython-buildarea/3.7.edelsohn-debian-z/build/Lib/pty.py", line 29, in openpty
    master_fd, slave_name = _open_terminal()
  File "/home/dje/cpython-buildarea/3.7.edelsohn-debian-z/build/Lib/pty.py", line 59, in _open_terminal
    raise OSError('out of pty devices')
OSError: out of pty devices


Traceback (most recent call last):
  File "/home/dje/cpython-buildarea/3.7.edelsohn-debian-z/build/Lib/test/support/__init__.py", line 623, in wrapper
    return func(*args, **kw)
  File "/home/dje/cpython-buildarea/3.7.edelsohn-debian-z/build/Lib/test/test_asyncio/test_events.py", line 1601, in test_write_pty
    master, slave = os.openpty()
FileNotFoundError: [Errno 2] No such file or directory


Traceback (most recent call last):
  File "/home/dje/cpython-buildarea/3.7.edelsohn-debian-z/build/Lib/test/test_asyncio/test_events.py", line 1503, in test_read_pty_output
    master, slave = os.openpty()
FileNotFoundError: [Errno 2] No such file or directory


Traceback (most recent call last):
  File "/home/dje/cpython-buildarea/3.7.edelsohn-debian-z/build/Lib/test/test_readline.py", line 226, in test_nonascii
    output = run_pty(script, input)
  File "/home/dje/cpython-buildarea/3.7.edelsohn-debian-z/build/Lib/test/test_readline.py", line 285, in run_pty
    [master, slave] = pty.openpty()
  File "/home/dje/cpython-buildarea/3.7.edelsohn-debian-z/build/Lib/pty.py", line 29, in openpty
    master_fd, slave_name = _open_terminal()
  File "/home/dje/cpython-buildarea/3.7.edelsohn-debian-z/build/Lib/pty.py", line 59, in _open_terminal
    raise OSError('out of pty devices')
OSError: out of pty devices


Traceback (most recent call last):
  File "/home/dje/cpython-buildarea/3.7.edelsohn-debian-z/build/Lib/test/test_os.py", line 3273, in test_openpty
    master_fd, slave_fd = os.openpty()
FileNotFoundError: [Errno 2] No such file or directory

hroncok pushed a commit to hroncok/cpython that referenced this pull request Aug 14, 2020
test_ssl now handles disabled TLS/SSL versions better. OpenSSL's crypto
policy and run-time settings are recognized and tests for disabled versions
are skipped.

Signed-off-by: Christian Heimes <[email protected]>

https://bugs.python.org/issue38275
(cherry picked from commit df6ac7e)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
tests Tests in the Lib/test dir
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants