Skip to content

[3.8] bpo-38275: Skip ssl tests for disabled versions (GH-16386) #16425

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Sep 26, 2019

Conversation

tiran
Copy link
Member

@tiran tiran commented Sep 26, 2019

test_ssl now handles disabled TLS/SSL versions better. OpenSSL's crypto
policy and run-time settings are recognized and tests for disabled versions
are skipped.

Signed-off-by: Christian Heimes [email protected]

https://bugs.python.org/issue38275
(cherry picked from commit df6ac7e)

Co-authored-by: Christian Heimes [email protected]

https://bugs.python.org/issue38275

test_ssl now handles disabled TLS/SSL versions better. OpenSSL's crypto
policy and run-time settings are recognized and tests for disabled versions
are skipped.

Signed-off-by: Christian Heimes <[email protected]>

https://bugs.python.org/issue38275
(cherry picked from commit df6ac7e)

Co-authored-by: Christian Heimes <[email protected]>
@tiran
Copy link
Member Author

tiran commented Sep 26, 2019

PR needs fix from GH-16428

Check presence of SSLContext.minimum_version to make tests pass with
old versions of OpenSSL.

Signed-off-by: Christian Heimes <[email protected]>
@tiran
Copy link
Member Author

tiran commented Sep 26, 2019

I have cherry-picked commit 34992cf into this backport.

@tiran tiran merged commit 1931132 into python:3.8 Sep 26, 2019
@tiran tiran deleted the backport-df6ac7e-3.8 branch September 26, 2019 20:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
tests Tests in the Lib/test dir
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants