Skip to content

gh-130185: Fix unintentionally skipped tests in test_functools #130186

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 16, 2025
Merged

gh-130185: Fix unintentionally skipped tests in test_functools #130186

merged 1 commit into from
Feb 16, 2025

Conversation

tomasr8
Copy link
Member

@tomasr8 tomasr8 commented Feb 16, 2025 •
edited by bedevere-app bot
Loading

before:

Total tests: run=304

after:

Total tests: run=306

@tomasr8 tomasr8 requested a review from rhettinger as a code owner February 16, 2025 12:38
@bedevere-app bedevere-app bot added tests Tests in the Lib/test dir awaiting review labels Feb 16, 2025
@bedevere-app bedevere-app bot mentioned this pull request Feb 16, 2025
Closed
@tomasr8 tomasr8 added needs backport to 3.12 only security fixes needs backport to 3.13 bugs and security fixes labels Feb 16, 2025
sobolevn
sobolevn approved these changes Feb 16, 2025
View reviewed changes
Copy link
Member

@sobolevn sobolevn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good find!

@tomasr8
Copy link
Member Author

tomasr8 commented Feb 16, 2025

FWIW I wrote a script to check all tests under Lib/test and didn't find any other (obvious) instances of unintentionally skipped tests.

@sobolevn sobolevn merged commit 73d0300 into python:main Feb 16, 2025
52 checks passed
@miss-islington-app
Copy link

Thanks @tomasr8 for the PR, and @sobolevn for merging it 🌮🎉.. I'm working now to backport this PR to: 3.12, 3.13.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Feb 16, 2025
@tomasr8 @miss-islington
pythongh-130185: Fix unintentionally skipped tests in test_functools (
dba6d4b 
pythonGH-130186)

(cherry picked from commit 73d0300)

Co-authored-by: Tomas R. <[email protected]>
@bedevere-app
Copy link

bedevere-app bot commented Feb 16, 2025

GH-130188 is a backport of this pull request to the 3.13 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.13 bugs and security fixes label Feb 16, 2025
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Feb 16, 2025
@tomasr8 @miss-islington
pythongh-130185: Fix unintentionally skipped tests in test_functools (
934cfc8 
pythonGH-130186)

(cherry picked from commit 73d0300)

Co-authored-by: Tomas R. <[email protected]>
@bedevere-app
Copy link

bedevere-app bot commented Feb 16, 2025

GH-130189 is a backport of this pull request to the 3.12 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.12 only security fixes label Feb 16, 2025
sobolevn pushed a commit that referenced this pull request Feb 16, 2025
@miss-islington @tomasr8
[3.12] gh-130185: Fix unintentionally skipped tests in `test_functool…
4f09a85 
…s` (GH-130186) (#130189)

gh-130185: Fix unintentionally skipped tests in `test_functools` (GH-130186)
(cherry picked from commit 73d0300)

Co-authored-by: Tomas R <[email protected]>
sobolevn pushed a commit that referenced this pull request Feb 16, 2025
@miss-islington @tomasr8
[3.13] gh-130185: Fix unintentionally skipped tests in `test_functool…
ff92f6b 
…s` (GH-130186) (#130188)

gh-130185: Fix unintentionally skipped tests in `test_functools` (GH-130186)
(cherry picked from commit 73d0300)

Co-authored-by: Tomas R <[email protected]>
@tomasr8 tomasr8 deleted the functools-tests branch February 16, 2025 14:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sobolevn sobolevn sobolevn approved these changes

@rhettinger rhettinger Awaiting requested review from rhettinger rhettinger is a code owner

Assignees
No one assigned
Labels
skip news tests Tests in the Lib/test dir
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tomasr8 @sobolevn