Skip to content

Some tests are skipped in test_functools #130185

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
tomasr8 opened this issue Feb 16, 2025 · 1 comment
Closed

Some tests are skipped in test_functools #130185

tomasr8 opened this issue Feb 16, 2025 · 1 comment
Assignees
@tomasr8
Labels
3.12 only security fixes 3.13 bugs and security fixes 3.14 bugs and security fixes tests Tests in the Lib/test dir type-bug An unexpected behavior, bug, or error

Comments

@tomasr8
Copy link
Member

tomasr8 commented Feb 16, 2025 •
edited by bedevere-app bot
Loading

Bug report

Bug description:

TestCache is not used by any other test class in the module. I'm guessing it was intended to be used as TestLRU but it currently does not run:

cpython/Lib/test/test_functools.py

Lines 1474 to 1476 in 9837c2a

class TestCache:
# This tests that the pass-through is working as designed.
# The underlying functionality is tested in TestLRU.

CPython versions tested on:

CPython main branch

Operating systems tested on:

No response

Linked PRs
@tomasr8 tomasr8 added 3.12 only security fixes 3.13 bugs and security fixes tests Tests in the Lib/test dir type-bug An unexpected behavior, bug, or error labels Feb 16, 2025
@tomasr8 tomasr8 self-assigned this Feb 16, 2025
@bedevere-app bedevere-app bot mentioned this issue Feb 16, 2025
Merged
@picnixz picnixz added the 3.14 bugs and security fixes label Feb 16, 2025
sobolevn pushed a commit that referenced this issue Feb 16, 2025
@tomasr8
gh-130185: Fix unintentionally skipped tests in test_functools (#13…
73d0300 
…0186)
miss-islington pushed a commit to miss-islington/cpython that referenced this issue Feb 16, 2025
@tomasr8 @miss-islington
pythongh-130185: Fix unintentionally skipped tests in test_functools (
dba6d4b 
pythonGH-130186)

(cherry picked from commit 73d0300)

Co-authored-by: Tomas R. <[email protected]>
miss-islington pushed a commit to miss-islington/cpython that referenced this issue Feb 16, 2025
@tomasr8 @miss-islington
pythongh-130185: Fix unintentionally skipped tests in test_functools (
934cfc8 
pythonGH-130186)

(cherry picked from commit 73d0300)

Co-authored-by: Tomas R. <[email protected]>
This was referenced Feb 16, 2025
Merged
Merged
sobolevn pushed a commit that referenced this issue Feb 16, 2025
@miss-islington @tomasr8
[3.12] gh-130185: Fix unintentionally skipped tests in `test_functool…
4f09a85 
…s` (GH-130186) (#130189)

gh-130185: Fix unintentionally skipped tests in `test_functools` (GH-130186)
(cherry picked from commit 73d0300)

Co-authored-by: Tomas R <[email protected]>
sobolevn pushed a commit that referenced this issue Feb 16, 2025
@miss-islington @tomasr8
[3.13] gh-130185: Fix unintentionally skipped tests in `test_functool…
ff92f6b 
…s` (GH-130186) (#130188)

gh-130185: Fix unintentionally skipped tests in `test_functools` (GH-130186)
(cherry picked from commit 73d0300)

Co-authored-by: Tomas R <[email protected]>
@sobolevn
Copy link
Member

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tomasr8 tomasr8

Labels
3.12 only security fixes 3.13 bugs and security fixes 3.14 bugs and security fixes tests Tests in the Lib/test dir type-bug An unexpected behavior, bug, or error
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@sobolevn @tomasr8 @picnixz