bpo-35433: Properly detect installed SDK versions #11009

jkloth · 2018-12-07T01:08:33Z

https://bugs.python.org/issue35433

jkloth · 2018-12-07T01:33:35Z

PCbuild/python.props

+    <_RegistryVersion Condition="$(_RegistryVersion) != '' and !$(_RegistryVersion.EndsWith('.0'))">$(_RegistryVersion).0</_RegistryVersion>
+
+    <!-- The minimum allowed SDK version to use for building -->
+    <DefaultWindowsSDKVersion>10.0.10586.0</DefaultWindowsSDKVersion>


I chose this SDK version as the minimum as I remember an issue ~5 years ago that was solved by using this version instead of an earlier one (although possibly pre-release).

vstinner · 2018-12-07T09:55:19Z

@zware, @zooba: Would you mind to have a look at this PR? @jkloth asked me to review it, but I don't know such VS specific feature.

@jkloth: You have to rebase/update your PR, there is a conflict: PCbuild/python.props

vstinner · 2018-12-07T09:55:56Z

FYI it seems like PR #10245 introduced the conflict.

vstinner · 2018-12-07T12:43:22Z

@zware, @zooba: Would you mind to have a look at this PR? @jkloth asked me to review it, but I don't know such VS specific feature.

Aha, @zooba approved the change in the bug tracker, but not here:
https://bugs.python.org/issue35433#msg331263

@zooba: I would prefer that you explicitly approve this change, since there are conflicts with your https://bugs.python.org/issue34977 change.

zooba · 2018-12-07T15:18:56Z

PCbuild/python.props

+
+    <!-- The minimum allowed SDK version to use for building -->
+    <DefaultWindowsSDKVersion>10.0.10586.0</DefaultWindowsSDKVersion>
+    <DefaultWindowsSDKVersion Condition="$(_RegistryVersion.CompareTo($(DefaultWindowsSDKVersion))) >= 0">$(_RegistryVersion)</DefaultWindowsSDKVersion>


I just learned that a better way to spell this is:

$([System.Version]::Parse($(_RegistryVersion))) > $([System.Version]::Parse($(DefaultWindowsSDKVersion)))

For the SDK version it probably won't matter though. The numbering scheme is going to remain the same length for a while.

zooba · 2018-12-07T15:20:13Z

There are no conflicts. The only reason I didn't directly approve is because I was on my phone at the time and I can't post to GitHub properly from my phone (one of the reasons I voted against the move, and continue to vote against the move to put all issues on here).

In fixing my other PR, I found a better way to do the version comparison. So approved pending that change.

vstinner · 2018-12-07T15:21:39Z

There are no conflicts.

Your two PRs modified the same file and the Merge button was disabled because of that. It's back to green because I reverted your App Store change.

zooba · 2018-12-07T15:23:37Z

Oh I see. In that case, this change will make mine unnecessary, but it's not directly related.

Added computed SDK version to ShowVersionInfo.

miss-islington · 2018-12-10T03:59:35Z

Thanks @jkloth for the PR, and @zooba for merging it 🌮🎉.. I'm working now to backport this PR to: 3.6, 3.7.
🐍🍒⛏🤖

(cherry picked from commit f46eccd) Co-authored-by: Jeremy Kloth <[email protected]>

bedevere-bot · 2018-12-10T03:59:50Z

GH-11058 is a backport of this pull request to the 3.7 branch.

miss-islington · 2018-12-10T03:59:53Z

Sorry, @jkloth and @zooba, I could not cleanly backport this to 3.6 due to a conflict.
Please backport using cherry_picker on command line.
cherry_picker f46eccd0ffe65333035c3820886295b71c41ab6e 3.6

bedevere-bot · 2018-12-10T04:03:49Z

GH-11059 is a backport of this pull request to the 3.6 branch.

(cherry picked from commit f46eccd) Co-authored-by: Jeremy Kloth <[email protected]>

bedevere-bot · 2018-12-10T20:44:24Z

⚠️⚠️⚠️ Buildbot failure ⚠️⚠️⚠️

Hi! The buildbot AMD64 Windows8 3.6 has failed when building commit f04cc5f.

What do you need to do:

Don't panic.
Check the buildbot page in the devguide if you don't know what the buildbots are or how they work.
Go to the page of the buildbot that failed (https://buildbot.python.org/all/#builders/38/builds/750) and take a look at the build logs.
Check if the failure is related to this commit (f04cc5f) or if it is a false positive.
If the failure is related to this commit, please, reflect that on the issue and make a new Pull Request with a fix.

You can take a look at the buildbot page here:

https://buildbot.python.org/all/#builders/38/builds/750

Click to see traceback logs

From https://github.com/python/cpython
 * branch            3.6        -> FETCH_HEAD
Reset branch '3.6'

Could Not Find D:\buildarea\3.6.bolen-windows8\build\Lib\*.pyc
The system cannot find the file specified.
Could Not Find D:\buildarea\3.6.bolen-windows8\build\PCbuild\python*.zip

Could Not Find D:\buildarea\3.6.bolen-windows8\build\Lib\*.pyc
The system cannot find the file specified.
Could Not Find D:\buildarea\3.6.bolen-windows8\build\PCbuild\python*.zip

bedevere-bot · 2018-12-10T20:56:04Z

⚠️⚠️⚠️ Buildbot failure ⚠️⚠️⚠️

Hi! The buildbot AMD64 Windows10 3.6 has failed when building commit f04cc5f.

What do you need to do:

Don't panic.
Check the buildbot page in the devguide if you don't know what the buildbots are or how they work.
Go to the page of the buildbot that failed (https://buildbot.python.org/all/#builders/31/builds/718) and take a look at the build logs.
Check if the failure is related to this commit (f04cc5f) or if it is a false positive.
If the failure is related to this commit, please, reflect that on the issue and make a new Pull Request with a fix.

You can take a look at the buildbot page here:

https://buildbot.python.org/all/#builders/31/builds/718

Click to see traceback logs

From https://github.com/python/cpython
 * branch            3.6        -> FETCH_HEAD
Reset branch '3.6'

Could Not Find D:\buildarea\3.6.bolen-windows10\build\Lib\*.pyc
The system cannot find the file specified.
Could Not Find D:\buildarea\3.6.bolen-windows10\build\PCbuild\python*.zip

Could Not Find D:\buildarea\3.6.bolen-windows10\build\Lib\*.pyc
The system cannot find the file specified.
Could Not Find D:\buildarea\3.6.bolen-windows10\build\PCbuild\python*.zip

jkloth · 2018-12-10T21:13:48Z

Without knowing what version of VS2015 is used on Davd Bolen's buildbots for 3.6 these errors are nigh impossible to fix... These changes now force VS2015 to use the Win10 SDK whereas prior it was defaulting to the 8.1 SDK.

I have a message out to David regarding this.

bedevere-bot · 2018-12-10T21:43:08Z

⚠️⚠️⚠️ Buildbot failure ⚠️⚠️⚠️

Hi! The buildbot AMD64 Windows8 3.6 has failed when building commit f04cc5f.

What do you need to do:

Don't panic.
Check the buildbot page in the devguide if you don't know what the buildbots are or how they work.
Go to the page of the buildbot that failed (https://buildbot.python.org/all/#builders/38/builds/751) and take a look at the build logs.
Check if the failure is related to this commit (f04cc5f) or if it is a false positive.
If the failure is related to this commit, please, reflect that on the issue and make a new Pull Request with a fix.

You can take a look at the buildbot page here:

https://buildbot.python.org/all/#builders/38/builds/751

Click to see traceback logs

Reset branch '3.6'

Could Not Find D:\buildarea\3.6.bolen-windows8\build\Lib\*.pyc
The system cannot find the file specified.
Could Not Find D:\buildarea\3.6.bolen-windows8\build\PCbuild\python*.zip

Could Not Find D:\buildarea\3.6.bolen-windows8\build\Lib\*.pyc
The system cannot find the file specified.
Could Not Find D:\buildarea\3.6.bolen-windows8\build\PCbuild\python*.zip

bedevere-bot · 2018-12-10T21:43:32Z

⚠️⚠️⚠️ Buildbot failure ⚠️⚠️⚠️

Hi! The buildbot AMD64 Windows10 3.6 has failed when building commit f04cc5f.

What do you need to do:

Don't panic.
Check the buildbot page in the devguide if you don't know what the buildbots are or how they work.
Go to the page of the buildbot that failed (https://buildbot.python.org/all/#builders/31/builds/719) and take a look at the build logs.
Check if the failure is related to this commit (f04cc5f) or if it is a false positive.
If the failure is related to this commit, please, reflect that on the issue and make a new Pull Request with a fix.

You can take a look at the buildbot page here:

https://buildbot.python.org/all/#builders/31/builds/719

Click to see traceback logs

Reset branch '3.6'

Could Not Find D:\buildarea\3.6.bolen-windows10\build\Lib\*.pyc
The system cannot find the file specified.
Could Not Find D:\buildarea\3.6.bolen-windows10\build\PCbuild\python*.zip

Could Not Find D:\buildarea\3.6.bolen-windows10\build\Lib\*.pyc
The system cannot find the file specified.
Could Not Find D:\buildarea\3.6.bolen-windows10\build\PCbuild\python*.zip

pablogsal · 2018-12-10T21:45:15Z

This commit broke the following (at least) the buildbots:

https://buildbot.python.org/all/#/builders/38/builds/751
https://buildbot.python.org/all/#/builders/31/builds/719

can someone work on a fix? Otherwise we would have to revert the commit per our policy with buildbot failures

jkloth · 2018-12-11T01:43:23Z

There is a bit of a catch-22 here, if the changes get reverted, a different buildbot will be broken. Note that this is also actively being investigated,

bedevere-bot · 2018-12-11T03:50:33Z

⚠️⚠️⚠️ Buildbot failure ⚠️⚠️⚠️

Hi! The buildbot AMD64 Windows10 3.6 has failed when building commit f04cc5f.

What do you need to do:

Don't panic.
Check the buildbot page in the devguide if you don't know what the buildbots are or how they work.
Go to the page of the buildbot that failed (https://buildbot.python.org/all/#builders/31/builds/720) and take a look at the build logs.
Check if the failure is related to this commit (f04cc5f) or if it is a false positive.
If the failure is related to this commit, please, reflect that on the issue and make a new Pull Request with a fix.

You can take a look at the buildbot page here:

https://buildbot.python.org/all/#builders/31/builds/720

Click to see traceback logs

Reset branch '3.6'

Could Not Find D:\buildarea\3.6.bolen-windows10\build\Lib\*.pyc
The system cannot find the file specified.
Could Not Find D:\buildarea\3.6.bolen-windows10\build\PCbuild\python*.zip

Could Not Find D:\buildarea\3.6.bolen-windows10\build\Lib\*.pyc
The system cannot find the file specified.
Could Not Find D:\buildarea\3.6.bolen-windows10\build\PCbuild\python*.zip

bpo-35433: Properly detect installed SDK versions

132dae2

jkloth requested a review from a team as a code owner December 7, 2018 01:08

bedevere-bot added the awaiting review label Dec 7, 2018

jkloth commented Dec 7, 2018

View reviewed changes

vstinner requested review from zware and zooba December 7, 2018 09:54

zooba reviewed Dec 7, 2018

View reviewed changes

zooba added the skip news label Dec 7, 2018

jkloth added 2 commits December 9, 2018 08:13

Enable display of computed build properties in ShowVersionInfo

21dd59d

Use System.Version to compare SDK versions.

63e0321

Added computed SDK version to ShowVersionInfo.

zooba added needs backport to 3.6 OS-windows labels Dec 10, 2018

zooba merged commit f46eccd into python:master Dec 10, 2018

bedevere-bot removed the awaiting review label Dec 10, 2018

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Dec 10, 2018

bpo-35433: Properly detect installed SDK versions (pythonGH-11009)

42c7cc7

(cherry picked from commit f46eccd) Co-authored-by: Jeremy Kloth <[email protected]>

bedevere-bot removed the needs backport to 3.7 label Dec 10, 2018

miss-islington assigned zooba Dec 10, 2018

zooba pushed a commit to zooba/cpython that referenced this pull request Dec 10, 2018

bpo-35433: Properly detect installed SDK versions (pythonGH-11009)

32daaf5

bedevere-bot removed the needs backport to 3.6 label Dec 10, 2018

miss-islington added a commit that referenced this pull request Dec 10, 2018

bpo-35433: Properly detect installed SDK versions (GH-11009)

c83ec05

(cherry picked from commit f46eccd) Co-authored-by: Jeremy Kloth <[email protected]>

jkloth added a commit to jkloth/cpython that referenced this pull request Dec 10, 2018

[3.6] bpo-35433: Properly detect installed SDK versions (pythonGH-11009)

ac98aa4

zooba pushed a commit that referenced this pull request Dec 10, 2018

[3.6] bpo-35433: Properly detect installed SDK versions (GH-11009)

f04cc5f

jkloth deleted the issue35433 branch December 11, 2018 16:36

Uh oh!

bpo-35433: Properly detect installed SDK versions #11009

bpo-35433: Properly detect installed SDK versions #11009

Uh oh!

Conversation

jkloth commented Dec 7, 2018 • edited by bedevere-bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

jkloth Dec 7, 2018

Choose a reason for hiding this comment

Uh oh!

vstinner commented Dec 7, 2018

Uh oh!

vstinner commented Dec 7, 2018

Uh oh!

vstinner commented Dec 7, 2018

Uh oh!

zooba Dec 7, 2018

Choose a reason for hiding this comment

Uh oh!

zooba commented Dec 7, 2018

Uh oh!

vstinner commented Dec 7, 2018

Uh oh!

zooba commented Dec 7, 2018

Uh oh!

miss-islington commented Dec 10, 2018

Uh oh!

bedevere-bot commented Dec 10, 2018

Uh oh!

miss-islington commented Dec 10, 2018

Uh oh!

bedevere-bot commented Dec 10, 2018

Uh oh!

bedevere-bot commented Dec 10, 2018

⚠️⚠️⚠️ Buildbot failure ⚠️⚠️⚠️

Uh oh!

bedevere-bot commented Dec 10, 2018

⚠️⚠️⚠️ Buildbot failure ⚠️⚠️⚠️

Uh oh!

jkloth commented Dec 10, 2018

Uh oh!

bedevere-bot commented Dec 10, 2018

⚠️⚠️⚠️ Buildbot failure ⚠️⚠️⚠️

Uh oh!

bedevere-bot commented Dec 10, 2018

⚠️⚠️⚠️ Buildbot failure ⚠️⚠️⚠️

Uh oh!

pablogsal commented Dec 10, 2018

Uh oh!

jkloth commented Dec 11, 2018

Uh oh!

bedevere-bot commented Dec 11, 2018

⚠️⚠️⚠️ Buildbot failure ⚠️⚠️⚠️

Uh oh!

Uh oh!

jkloth commented Dec 7, 2018 •

edited by bedevere-bot

Loading