bpo-34977: Add Windows App Store package #10245
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maxbelanger
reviewed
Oct 31, 2018
|
For anyone looking at the change, once you get past |
zooba
added a commit
that referenced
this pull request
Dec 7, 2018
pablogsal
added a commit
that referenced
this pull request
Dec 7, 2018
|
|
|
|
|
|
vstinner
added a commit
that referenced
this pull request
Dec 7, 2018
|
|
zooba
added a commit
to zooba/cpython
that referenced
this pull request
Dec 10, 2018
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The main addition of this PR is the
PC/layoutscript that is basically a "make install" equivalent for Windows. It is able to include/exclude a range of components, and has the following output formats:To make the app store package work properly, I needed to add a new version of
python[w].exethat can correctly locate itself. To link to embedded scripts (pipandidle), this new launcher can also handle being renamed and will launch those modules instead. It also sets some environment variables to help pip always install to user site packages and keep those in an accessible location - it would be nice (but not essential) to set these defaults in other ways, but this is most reliable right now.To make venv work I modified the launcher to be able to launch the correct
python[w].exefrom a venv, so we no longer need to copy any other binaries into the Scripts directory. For recent releases of pip, this also works for launchers, but the embedded version of pip is too old.This is very close, but not quite yet ready to merge. Open to suggestions/changes here. For early releases, I'm planning to backport to a branch of 3.7 so we can put out 3.7.1 (hopefully) and also be able to run it against a 3.7 build, hopefully without having to backport too much. I've already obtained the PSF publisher on the store, and have checked that ownership/access can be transferred easily.
Can anyone think of anything I've missed?
https://bugs.python.org/issue34977