Fix the french used in the email documentation #106279
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The french used in one of the example was either machine translated a while ago or written by someone who does not speak french. Fixed it by using grammatically correct french.
|
Most changes to Python require a NEWS entry. Please add it using the blurb_it web app or the blurb command-line tool. |
|
All commit authors signed the Contributor License Agreement. |
bitdancer
requested changes
Jun 30, 2023
This comment was marked as resolved.
This comment was marked as resolved.
|
Oh, nevermind, I missed the fact that this was the docs. It looks fine. |
bitdancer
approved these changes
Jun 30, 2023
JulienPalard
reviewed
Jul 2, 2023
JulienPalard
reviewed
Jul 2, 2023
|
Thanks!! :)) |
|
I wish we stuck closer to the original French. It looked deliciously outmoded, typically an American trying to write French from what he had learned in school. It definitively had some charm. But thanks anyway |
deronnax
reviewed
Jul 16, 2023
| @@ -8,14 +8,14 @@ | |||
|
|
|||
| # Create the base text message. | |||
| msg = EmailMessage() | |||
| msg['Subject'] = "Ayons asperges pour le déjeuner" | |||
There was a problem hiding this comment.
pretty correct, it would have been:
Ayons des asperges pour le déjeuner
| msg['From'] = Address("Pepé Le Pew", "pepe", "example.com") | ||
| msg['To'] = (Address("Penelope Pussycat", "penelope", "example.com"), | ||
| Address("Fabrette Pussycat", "fabrette", "example.com")) | ||
| msg.set_content("""\ | ||
| Salut! | ||
|
|
||
| Cela ressemble à un excellent recipie[1] déjeuner. |
There was a problem hiding this comment.
A bit more wrong. The correct form would have been:
Cela ressemble à une excellente recette pour le déjeuner
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The french used in one of the example was either machine translated a while ago or written by someone who does not speak french. Fixed it by using grammatically correct french.
I could also change it to english if this is the preferred approach.
Since it is a trivial doc change, I did not make an issue.
📚 Documentation preview 📚: https://cpython-previews--106279.org.readthedocs.build/