Skip to content

Conversation

Objectivitix
Copy link
Contributor

@Objectivitix Objectivitix commented May 24, 2021

Relevant Issues

Closes issues #753 and #747, extends PR #726

Description

It was planned to incorporate these two categories in the same PR, however I didn't get enough quiz entries for them. But now, thanks to lak, I have enough! So in total, 60 new questions are added. I also changed the starting embed a bit to make it look nicer, made the variation tolerance stricter, and added some missing answers specified in 747 to the math & science questions.

Did you:

@Objectivitix
Copy link
Contributor Author

lint works, everything works, ready for review :D

Copy link
Contributor

@ToxicKidz ToxicKidz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey, you should test before you push, because I get this error when running the code:

Traceback (most recent call last):
   File "/usr/local/lib/python3.9/site-packages/discord/ext/commands/bot.py", line 618, in _load_from_module_spec
     setup(self)
   File "/bot/bot/exts/evergreen/trivia_quiz.py", line 593, in setup
     bot.add_cog(TriviaQuiz(bot))
   File "/bot/bot/exts/evergreen/trivia_quiz.py", line 202, in __init__
     self.questions = self.load_questions()
   File "/bot/bot/exts/evergreen/trivia_quiz.py", line 222, in load_questions
     return json.loads(p.read_text(encoding="utf-8"))
   File "/usr/local/lib/python3.9/json/__init__.py", line 346, in loads
     return _default_decoder.decode(s)
   File "/usr/local/lib/python3.9/json/decoder.py", line 340, in decode
     raise JSONDecodeError("Extra data", s, end)
 json.decoder.JSONDecodeError: Extra data: line 2 column 10 (char 10)

The problem is most likely because you removed the { here:

@Objectivitix
Copy link
Contributor Author

@ToxicKidz I did test all 60 questions before, the error arose during the commit (copy paste error smh). It has been resolved :D

@Objectivitix Objectivitix requested a review from ToxicKidz May 26, 2021 15:54
@Xithrius Xithrius added area: backend Related to internal functionality and utilities season: evergreen status: needs review Author is waiting for someone to review and approve type: enhancement Changes or improvements to existing features labels May 29, 2021
@Xithrius Xithrius requested review from vcokltfre and Xithrius May 29, 2021 04:35
@Objectivitix Objectivitix requested a review from ToxicKidz May 31, 2021 12:39
Copy link
Contributor

@Kronifer Kronifer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Few nitpicks here

@Kronifer
Copy link
Contributor

Kronifer commented Jun 1, 2021

Github seems to have added duplicate change requests, i did my best to remove them.

@Objectivitix
Copy link
Contributor Author

@Kronifer @ToxicKidz all your changes have been implemented.

@Objectivitix
Copy link
Contributor Author

@vcokltfre The changes will be implemented later, currently I gotta update my website lol :D

@Objectivitix Objectivitix requested a review from vcokltfre June 6, 2021 23:51
Copy link
Contributor

@vcokltfre vcokltfre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! :shipit:

@Objectivitix Objectivitix requested a review from ToxicKidz June 7, 2021 01:20
Copy link
Contributor

@ToxicKidz ToxicKidz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@Objectivitix
Copy link
Contributor Author

petapoggers :D one last core dev appr then we done

@HassanAbouelela HassanAbouelela merged commit 5ebe5ee into python-discord:main Jul 6, 2021
@Xithrius Xithrius removed the status: needs review Author is waiting for someone to review and approve label Nov 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: backend Related to internal functionality and utilities type: enhancement Changes or improvements to existing features
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants