-
-
Notifications
You must be signed in to change notification settings - Fork 256
Add "cs" and "python" categories to the .quiz
command (and more in desc)
#756
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
and modify a bit the starting phase (embed, asyncio delay)
lint works, everything works, ready for review :D |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey, you should test before you push, because I get this error when running the code:
Traceback (most recent call last):
File "/usr/local/lib/python3.9/site-packages/discord/ext/commands/bot.py", line 618, in _load_from_module_spec
setup(self)
File "/bot/bot/exts/evergreen/trivia_quiz.py", line 593, in setup
bot.add_cog(TriviaQuiz(bot))
File "/bot/bot/exts/evergreen/trivia_quiz.py", line 202, in __init__
self.questions = self.load_questions()
File "/bot/bot/exts/evergreen/trivia_quiz.py", line 222, in load_questions
return json.loads(p.read_text(encoding="utf-8"))
File "/usr/local/lib/python3.9/json/__init__.py", line 346, in loads
return _default_decoder.decode(s)
File "/usr/local/lib/python3.9/json/decoder.py", line 340, in decode
raise JSONDecodeError("Extra data", s, end)
json.decoder.JSONDecodeError: Extra data: line 2 column 10 (char 10)
The problem is most likely because you removed the {
here:
sir-lancebot/bot/resources/evergreen/trivia_quiz.json
Lines 1 to 3 in d832daa
"retro": [ | |
{ |
@ToxicKidz I did test all 60 questions before, the error arose during the commit (copy paste error smh). It has been resolved :D |
Co-authored-by: ToxicKidz <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Few nitpicks here
Github seems to have added duplicate change requests, i did my best to remove them. |
Also add an additional answer to the CRLF question
@Kronifer @ToxicKidz all your changes have been implemented. |
@vcokltfre The changes will be implemented later, currently I gotta update my website lol :D |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
(and a whole lotta backslashes)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
petapoggers :D one last core dev appr then we done |
Relevant Issues
Closes issues #753 and #747, extends PR #726
Description
It was planned to incorporate these two categories in the same PR, however I didn't get enough quiz entries for them. But now, thanks to lak, I have enough! So in total, 60 new questions are added. I also changed the starting embed a bit to make it look nicer, made the variation tolerance stricter, and added some missing answers specified in 747 to the math & science questions.
Did you: