Add "math" and "science" categories to the .quiz command (and more in desc)

[Objectivitix]

Relevant Issues

Closes #719

Description & Implementation

TL;DR - added multiple possible answers, images, dynamically generated questions and two new categories (60 questions in total)

PART ONE:
After gathering a database of questions and answers, I incorporated them into the json file. Some questions requiring images are supplemented with an "img_url" entry, and some requiring dynamic generation (e.g. Math Q1, a random system of linear equations with two unknowns) have an "dynamic_id" entry, which will come into use later.

PART TWO:

1. Added two new categories to the quiz: "math" and "science"! Also fixed some original flaws in the code so the abandoned category "retro" can function properly. Updated the documentation string in quiz_game to include these categories.
2. Implemented a "multiple possible answers" feature, where if a question can have multiple correct answers (usually synonyms and significant variations of a word which won't be tolerated by fuzz) they will all be correct. These correct answers will also be listed in the answer embed (send_answer), and are separated by commas in the json file.
3. Added support for questions requiring images (with an "img_url" entry) in the quiz_game method.
4. Added some preparation for the next commit, which will add in the formatting functions dictionary. More on that later.
5. Added a feature where the amount of questions can be specified with .quiz <category> <questions>. Also changed the default from 5 questions to 8 questions. Added error embeds which will be sent when questions is larger than the amount of questions in that category, or if it's less than 0 (0 just makes it default).
6. Lightly refactored the code, making it easier on the eyes by adding some logical spacing in dense areas, using literal concatenation on some long strings, etc.

PART THREE:
This is where all the dynamic questions come to life! Each dynamic question has an unique "dynamic_id", which corresponds to a function taking its "question" and "answer" as input, formats them, and returns them in a tuple. This is how the questions will be dynamically generated.

Images

Normal Q&A
Dynamically generated question
Question with image
Error embeds

Did you:

• Join the Python Discord Community?
• Read all the comments in this template?
• Ensure there is an issue open, or link relevant discord discussions?
• Read the contributing guidelines?

[Objectivitix]

converting to draft because i have to fix some linting fails

[Objectivitix]

all lint failures fixed, ready for review!

[Objectivitix]

REGARDING THE CS AND PYTHON QUESTIONS:

We... just didn't get that much questions, so I didn't add them into the database. Our list can be found here, and once we get 30 questions on each I might open a new PR

[Kronifer]

Lgtm, tested and works good

[Objectivitix]

backend? i'm adding more stuff for user features
hmm... might be because the code had been heavily modified to fit with the new image questions and dynamic questions lol

[Shivansh-007]

As a pure code review, this looks good to me

[Objectivitix]

woohoo

Requested changes applied

[decorator-factory]

Well, it's not very good that we have a piece of code nobody can understand. Code should be understandable by those who read it. If it's not, you should investigate and fix it.

From what I was able to gather from the code, game_status is a dict that maps a channel ID to a boolean flag. Its purpose is to make sure that at most one quiz is present in a channel, but to allow multiple quizzes in multiple channels.

So this is what I would do:

self.is_game_running: Dict[int, bool] = {}  # maps channel ID to whether a quiz is running in that channel

Now, you also have two other variables:

        self.game_owners = {} # A variable to store the person's ID who started the quiz game in a channel.
        self.player_scores = {}  # A variable to store all player's scores for a bot session.
        self.game_player_scores = {}  # A variable to store temporary game player's scores.

Do you see a pattern? All these 4 dicts take a channel ID and return a game state. So what you could do is put all that into one object:

class Game:
    def __init__(self, owner_id: int):
        self.owner_id = owner_id
        self._scores: Dict[int, int] = {}

    def add_score(self, player_id: int, score_delta: int) -> None:
        self._scores[player_id] = self._scores.get(player_id, 0)  + score_delta

    def player_scores(self) -> Sequence[Tuple[int, int]]:
        """Returns a list of (user_id, score) tuples"""
        return list(self._scores.items())

inside the Cog class:

self.games: Dict[int, Game] = {}  # maps channel ID to its current game

self.player_scores is actually not used at all (double-check, but it seems so), so remove it.

[Objectivitix]

@decorator-factory your changes have all been implemented (except for major refactoring) :D

[decorator-factory]

LGTM

[Xithrius]

@Objectivitix please resolve these conflicts.

[Objectivitix]

@Xithrius All conflicts have been resolved. Two are caused by the spring cleanup I believe, and so I selected the spring cleanup ones

[Xithrius]

Thank you, I'll do a final test and then give my thoughts.

Code looks good to me as of now.

[Xithrius]

It works well.

[Objectivitix]

ZETAPOGGERS