Skip to content

Fix deprecation warning #395

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 6, 2016
Merged

Fix deprecation warning #395

merged 1 commit into from
Nov 6, 2016

Conversation

rpkilby
Copy link
Contributor

@rpkilby rpkilby commented Sep 15, 2016

No description provided.

@pelme
Copy link
Member

pelme commented Sep 16, 2016

Hmm, is there any chance we could have our own test suite catch any pytest warnings and fail? We should never ship a version that gives pytest-warnings.

I have not seen this warning myself in pytest-django itself or in my own project, where does it show up?

@rpkilby
Copy link
Contributor Author

rpkilby commented Sep 16, 2016

I found this while fixing deprecation warnings for DRF. Running their test suite w/ the -Wonce flag generates this warning as well as the one from #393.

@rpkilby
Copy link
Contributor Author

rpkilby commented Sep 16, 2016

Hmm, is there any chance we could have our own test suite catch any pytest warnings and fail? We should never ship a version that gives pytest-warnings.

I was able to view errors w/ python -Wonce -m pytest. You could try to force errors w/ -Werror, but I was getting errors from other dependencies.

@blueyed
Copy link
Contributor

blueyed commented Sep 17, 2016

@pelme pelme merged commit 54b6cad into pytest-dev:master Nov 6, 2016
@pelme
Copy link
Member

pelme commented Nov 6, 2016

Thanks for this PR! I've opened a new issue to track catching warnings in our CI setup: #415

mfa pushed a commit to aexeagmbh/pytest-django that referenced this pull request May 17, 2017
timb07 pushed a commit to timb07/pytest-django that referenced this pull request May 26, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants