Skip to content

Check for deprecation warnings in our test suite / CI #415

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
pelme opened this issue Nov 6, 2016 · 2 comments
Open

Check for deprecation warnings in our test suite / CI #415

pelme opened this issue Nov 6, 2016 · 2 comments

Comments

@pelme
Copy link
Member

pelme commented Nov 6, 2016

See #393 and #395 for warnings that we missed. We need a way to make sure we put out warning-free releases.

@blueyed
Copy link
Contributor

blueyed commented Nov 6, 2016

Via pytest-warnings maybe?
#395 (comment)

Just using -Werror fails with the stdlib already:

Failed to import the site module
Traceback (most recent call last):
  File "…/pyenv/tmp-pytest-django-adi6OX/lib/python3.5/site.py", line 706, in <module>
    main()
  File "…/pyenv/tmp-pytest-django-adi6OX/lib/python3.5/site.py", line 686, in main
    paths_in_sys = addsitepackages(paths_in_sys)
  File "…/pyenv/tmp-pytest-django-adi6OX/lib/python3.5/site.py", line 285, in addsitepackages
    addsitedir(sitedir, known_paths)
  File "…/pyenv/tmp-pytest-django-adi6OX/lib/python3.5/site.py", line 207, in addsitedir
    addpackage(sitedir, name, known_paths)
  File "…/pyenv/tmp-pytest-django-adi6OX/lib/python3.5/site.py", line 168, in addpackage
    f = open(fullname, "rU")
DeprecationWarning: 'U' mode is deprecated

I could imagine to add some logfilter for this, but then it's probably what pytest-warnings does already?!

@pelme
Copy link
Member Author

pelme commented Nov 7, 2016

I haven't looked into it but we need something that fails CI on deprecation warnings in Django or pytest. Hopefully pytest-warnings does that out of the box. :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants