Limit sponsors logo size via CSS #9708
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
berinhard
changed the title
|
@ewdurbin for some reason I'm not being able to mark you as a reviewer, so I'm writing this comment so you can be notified about this PR 👍 Let me know if there's anything else to be done here. |
ewdurbin
approved these changes
Jun 22, 2021
|
Thank you @berinhard. @ejodlowska, once this deploys you should be able to update the affected sponsors in PyPI admin. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #9676
This PR updates the CSS for the footer and sponsors grid logos to limit their sizes. I didn't have to change anything to properly display the logo in the sidebar.
Anyway, the current CSS solution can be a kind of house of cards for future bigger logos. After we implement the logo upload in the admin form, definitely some type of thumbnail alternative generated with Pillow or opencv is something good to go with.
Here are screenshots from the final result from my local environment:
Footer
Sponsors grid
Sidebar