Skip to content

Updated settings.html #13310

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 27, 2023
Merged

Updated settings.html #13310

merged 2 commits into from
Mar 27, 2023

Conversation

sabre-code
Copy link
Contributor

@sabre-code sabre-code commented Mar 27, 2023

Addressed issue mentioned in this comment here #11985 (comment) @miketheman
Please check if it's exactly the way you suggested. Thanks

Fixes #13143.
Closes #13299

Addressed issue mentioned  in this comment here pypi#11985 (comment)
@miketheman 
Please check if it's exactly the way you suggested.
Thanks
@sabre-code sabre-code requested a review from a team as a code owner March 27, 2023 17:31
@di
Copy link
Member

di commented Mar 27, 2023

Hi @sabre-code, thanks for the PR. For future reference, you can link a pull request to it's issue using a keyword, like fixes #13143 which will automatically cause the issue to be closed when the pull request is merged.

(I've gone ahead and done it for you here as well!)

@sabre-code
Copy link
Contributor Author

Oh apologies for that and thanks.
It's my very first attempt to contributing on GitHub. So first merge as well. Will keep in mind next time. Thanks ❤️

@sabre-code
Copy link
Contributor Author

Hi @sabre-code, thanks for the PR. For future reference, you can link a pull request to it's issue using a keyword, like fixes #13143 which will automatically cause the issue to be closed when the pull request is merged.

(I've gone ahead and done it for you here as well!)

Just wanted to know whether the changes were as expected? as it shows here merging is blocked.

@di
Copy link
Member

di commented Mar 27, 2023

I also updated the translation files for you as well, since this changes translated strings.

Just wanted to know whether the changes were as expected? as it shows here merging is blocked.

Yes, this is because nobody has provided a review yet. I'll let @miketheman review as he was helping you in #11985.

@di di requested a review from miketheman March 27, 2023 17:53
Copy link
Member

@miketheman miketheman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@miketheman miketheman merged commit 03fe217 into pypi:main Mar 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Replace reference to setup.py in settings with pyproject.toml
3 participants