Updated settings.html #13299
Updated settings.html #13299
Conversation
Based on pypi#13143 . Code initially pointed to setup.py. Now it points to pyproject.toml
|
Thanks @sabre-code ! Did you see the open question on the original issue that was not addressed? |
|
Hello @miketheman. If you are hinting about the the link update issue, yes I have gone through it. Can you help me with what exactly should be updated as it's mentioned "change the name". And the part of updating the link to the one given in comment is clear to me. Just clarify the "name" thing. I will get it done. Thanks |
| @@ -102,7 +102,7 @@ <h3>{% trans %}<abbr title="two factor authentication">2FA</abbr> requirement{% | |||
| <h3>{% trans %}Project description and sidebar{% endtrans %}</h3> | |||
| <p> | |||
| {% trans project_name=project.name, setup_args_href='https://packaging.python.org/tutorials/distributing-packages/#setup-args', twine_docs_href='https://twine.readthedocs.io/en/latest/', distribution_href='https://packaging.python.org/tutorials/distributing-packages/' %} | |||
There was a problem hiding this comment.
On this line setup_args_href refers to setup.py arguments, which is then used in the content line.
Rename to something like pyproject_args_href and update the target URL to a correct anchor in the documentation, and then use the new name in line 105 <a href= tag
There was a problem hiding this comment.
#13310 Hello please check this. Done. If anything else happy to work it out.
Based on #13143 . Code initially pointed to setup.py. Now it points to pyproject.toml. Just want to know whether in the same line setup() should be changed with something else? If current change is fine please merge.