Fix bug in JAX cloning of RNG shared variables #315
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ricardoV94
changed the title
ricardoV94
force-pushed
the
fix_jax_jit_rng_bug
branch
2 times, most recently
from
ac8f1f2 to
02a0946
Compare
michaelosthege
approved these changes
May 23, 2023
ricardoV94
force-pushed
the
fix_jax_jit_rng_bug
branch
from
02a0946 to
6ce3527
Compare
|
Is this causing these tests to fail? https://github.com/pymc-devs/pytensor/actions/runs/5055033694/jobs/9070749041?pr=317 |
|
Yes this is failing because of JAX warnings when running on float32 |
ricardoV94
force-pushed
the
fix_jax_jit_rng_bug
branch
2 times, most recently
from
bdc8a2d to
9f2e09d
Compare
|
The tests failing are simply due to the new numba, they should pass once #317 goes through |
ricardoV94
force-pushed
the
fix_jax_jit_rng_bug
branch
from
9f2e09d to
f370938
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #314