Revert "Run numba tests in python 3.10 instead of 3.11"

[ricardoV94]

This reverts commit 277559b and tests numba compatibility with py311

Closes #239

[ricardoV94]

One test with a Categorical seems to fail. I think this was already fixed or marked as ignored upstream in Aesara.

Some tests are xpassing where we can remove the mark.

[ricardoV94]

Should we add the new numba version as a lower dependency?

This PR is not yet using any new functionality from the latest version. Simply marked some tests as xfail and fixed a bug with Categorical that should become irrelevant after #316

[codecov-commenter]

Codecov Report

Merging #317 (2c3504c) into main (203d919) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Additional details and impacted files

@@           Coverage Diff           @@
##             main     #317   +/-   ##
=======================================
  Coverage   80.50%   80.51%           
=======================================
  Files         154      154           
  Lines       45207    45210    +3     
  Branches    11048    11049    +1     
=======================================
+ Hits        36396    36400    +4     
+ Misses       6610     6609    -1     
  Partials     2201     2201           

Impacted Files	Coverage Δ
pytensor/link/numba/dispatch/random.py	98.83% <100.00%> (+0.02%)	⬆️

... and 1 file with indirect coverage changes

[michaelosthege]

Should we add the new numba version as a lower dependency?

For the package or for the test environment?

I would not add it for the package, but for the test environment it might be a good idea

[ricardoV94]

Updated the numba version used in the CI and dev environment

[ricardoV94]

Tests are passing can I get a thumbs up @michaelosthege / @maresb ?

[maresb]

It looks to me like there are currently no tests running without Numba. If this is the case and I'm not just missing something, maybe it'd make sense to add Numba as a dependency in pyproject.toml?

[maresb]

Up to that question about adding Numba as a dep, LGTM.

[ricardoV94]

It looks to me like there are currently no tests running without Numba.

What do you mean? Most tests don't run with numba at all.
Numba is a developer dependency and installed manually in the CI.
Numba is an optional dependency in pyproject.toml as well, just not pinning the latest version, as no feature directly depends on it:

pytensor/pyproject.toml

Lines 102 to 105 in f0fda41

	numba = [
	"numba>=0.55",
	"numba-scipy>=0.3.0"
	]

[ricardoV94]

Merging this to unblock other PRs, but let me know if you think we should bump numba min version in the toml as well

[maresb]

Ah, what I said was a bit ambiguous. I meant about Numba being always installed in all the environments in which pytest is run for the CI testing workflow. Specifically, can you point to any particular pytest run in the test workflow which executes in an environment where numba is not installed?

[ricardoV94]

Ah, what I said was a bit ambiguous. I meant about Numba being always installed in all the environments in which pytest is run for the CI testing workflow. Specifically, can you point to any particular pytest run in the test workflow which executes in an environment where numba is not installed?

Ah, no that doesn't currently happen the way we split the CIs, but we could easily have the numba ones run on their own job. It used to be distinict before

[maresb]

Ok, we might want to split the CIs if we want tests to cover the case of accidentally triggering Numba when it's not supposed to be used. Would this be useful?

[ricardoV94]

You mean testing that PyTensor works without numba being installed? Yes that could be useful

[maresb]

Exactly.