-
Notifications
You must be signed in to change notification settings - Fork 135
Revert "Run numba tests in python 3.10 instead of 3.11" #317
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
One test with a Categorical seems to fail. I think this was already fixed or marked as ignored upstream in Aesara. Some tests are xpassing where we can remove the mark. |
8a83452
to
8020f42
Compare
Should we add the new numba version as a lower dependency? This PR is not yet using any new functionality from the latest version. Simply marked some tests as xfail and fixed a bug with Categorical that should become irrelevant after #316 |
8020f42
to
2c3504c
Compare
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #317 +/- ##
=======================================
Coverage 80.50% 80.51%
=======================================
Files 154 154
Lines 45207 45210 +3
Branches 11048 11049 +1
=======================================
+ Hits 36396 36400 +4
+ Misses 6610 6609 -1
Partials 2201 2201
|
For the package or for the test environment? I would not add it for the package, but for the test environment it might be a good idea |
2c3504c
to
b857adb
Compare
Updated the numba version used in the CI and dev environment |
This reverts commit 277559b.
b857adb
to
b505ff2
Compare
595e219
to
1d53061
Compare
Tests are passing can I get a thumbs up @michaelosthege / @maresb ? |
It looks to me like there are currently no tests running without Numba. If this is the case and I'm not just missing something, maybe it'd make sense to add Numba as a dependency in |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Up to that question about adding Numba as a dep, LGTM.
What do you mean? Most tests don't run with numba at all. Lines 102 to 105 in f0fda41
|
Merging this to unblock other PRs, but let me know if you think we should bump numba min version in the toml as well |
Ah, what I said was a bit ambiguous. I meant about Numba being always installed in all the environments in which pytest is run for the CI testing workflow. Specifically, can you point to any particular pytest run in the test workflow which executes in an environment where numba is not installed? |
Ah, no that doesn't currently happen the way we split the CIs, but we could easily have the numba ones run on their own job. It used to be distinict before |
Ok, we might want to split the CIs if we want tests to cover the case of accidentally triggering Numba when it's not supposed to be used. Would this be useful? |
You mean testing that PyTensor works without numba being installed? Yes that could be useful |
Exactly. |
This reverts commit 277559b and tests numba compatibility with py311
Closes #239