-
-
Notifications
You must be signed in to change notification settings - Fork 2.1k
Combine test workflows into one #5623
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
The steps within each job were not changed in this commit.
Codecov Report
@@ Coverage Diff @@
## main #5623 +/- ##
==========================================
- Coverage 87.67% 87.63% -0.04%
==========================================
Files 76 76
Lines 13717 13717
==========================================
- Hits 12026 12021 -5
- Misses 1691 1696 +5
|
4d717af
to
24d3ed3
Compare
Looking at the runtime there are 4 or 5 workflows that took ~6 minutes to run, one of which only spent 45 seconds running actual tests, and the rest was setting up the environment https://github.com/pymc-devs/pymc/runs/5612971573?check_suite_focus=true I would merge those short workflows with some of the others that take like 11 minutes. We still have some workflows that take ~30 minutes, so we will not loose anything by merging the fast ones. |
c44de15
to
b320df9
Compare
I aimed for 15-20 minutes per job. Only the I was about to comment final success, but then I noticed that the Windows jobs were only running the first item in each subset 😮 And that was already the case on Some stats compared to 849a64d:
|
6a8b2f7
to
c3c383f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM,
This also explains why the windows xfails were not failing with strict XPASS in the past
Failing test seems to be #5575 I'll try to fix it this week. Shouldn't be a blocker here |
c3c383f
to
a9955ac
Compare
I noticed that the My last force-push moved mixture tests between the ubuntu groups to shave the longest job runtime down. I'm going to rebase-merge since there's no need to run the CI again. |
This PR combines
pytest
,arviz-compat
andjaxtests
workflows into one (big)tests
workflow.Motivations
pre-commit
(Adjust pre-commit step in CI to run every time, but fast fail if red #5041), having all jobs in one workflows will make it a lot easier.Changes
buildosx
build script. Chris confirmed via Slack that it can be removed.arviz-compat
andjaxtests
were deleted - their jobs were moved intotests
(previouslypytest
.ubuntu 18.04
to20.04
which is the most recent LTS release.