Skip to content

Added python3.10 env #5638

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 5 commits into from
Closed

Added python3.10 env #5638

wants to merge 5 commits into from

Conversation

5hv5hvnk
Copy link
Member

Ran test suit and added coda environment for python 3.10

resolves #5209

@ricardoV94
Copy link
Member

ricardoV94 commented Mar 22, 2022

You seem to have based your branch on an old version of the repository. The tests were recently merged into a single file: #5623

@michaelosthege
Copy link
Member

Just start fresh from the latest main branch. Trying to resolve the git conflicts would be much more work than reapplying them manually.

And make sure that you only commit the necessary files. There are some coverage files that should not be git committed.

@codecov
Copy link

codecov bot commented Mar 22, 2022

Codecov Report

Merging #5638 (917d7f0) into main (7a6bd02) will not change coverage.
The diff coverage is n/a.

❗ Current head 917d7f0 differs from pull request most recent head 5182ae7. Consider uploading reports for the commit 5182ae7 to get more accurate results

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #5638   +/-   ##
=======================================
  Coverage   88.57%   88.57%           
=======================================
  Files          75       75           
  Lines       13677    13677           
=======================================
  Hits        12114    12114           
  Misses       1563     1563           

@ricardoV94
Copy link
Member

You still seem to have committed 3 files that shouldn't have been committed: https://github.com/pymc-devs/pymc/pull/5638/files

@ricardoV94
Copy link
Member

ricardoV94 commented Mar 22, 2022

And you will need to swap the conda environment used in the tests to use this new one (and delete the old py37 environments): https://github.com/pymc-devs/pymc/blob/main/.github/workflows/tests.yml

@ricardoV94
Copy link
Member

@michaelosthege Could the failing tests be a conda cache issue?

@michaelosthege
Copy link
Member

I don't know about conda caching.

But the changes in test.yml affect all jobs at the same so it's really hard to tell. The current changes are

  • Ubuntu 3.73.8
  • Windows 3.83.9
  • MacOS 3.93.10
  • Ubuntu/Jax 3.93.10
  • Windows/float32 3.83.9

The Windows jobs are failing because the corresponding environment YAML does not exist.

The MacOS jobs fail because of build problems?

→→ I would advise to first bump only the Ubuntu job from 3.73.10 to see if it's even working there. But the Ubuntu/Jax job also has build problems, so the answer is likely "No"

@5hv5hvnk 5hv5hvnk closed this Apr 22, 2022
@5hv5hvnk 5hv5hvnk deleted the my-cool-bugfix branch April 22, 2022 06:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Run test suite on Python 3.10
3 participants