Skip to content

Unpin aeppl version #5203

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Nov 21, 2021
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion conda-envs/environment-dev-py37.yml
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ channels:
- conda-forge
- defaults
dependencies:
- aeppl=0.0.15
- aeppl>=0.0.17
- aesara>=2.2.6
- arviz>=0.11.4
- cachetools>=4.2.1
Expand Down
2 changes: 1 addition & 1 deletion conda-envs/environment-dev-py38.yml
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ channels:
- conda-forge
- defaults
dependencies:
- aeppl=0.0.15
- aeppl>=0.0.17
- aesara>=2.2.6
- arviz>=0.11.4
- cachetools>=4.2.1
Expand Down
2 changes: 1 addition & 1 deletion conda-envs/environment-dev-py39.yml
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ channels:
- conda-forge
- defaults
dependencies:
- aeppl=0.0.15
- aeppl>=0.0.17
- aesara>=2.2.6
- arviz>=0.11.4
- cachetools>=4.2.1
Expand Down
2 changes: 1 addition & 1 deletion conda-envs/environment-test-py37.yml
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ channels:
- conda-forge
- defaults
dependencies:
- aeppl=0.0.15
- aeppl>=0.0.17
- aesara>=2.2.6
- arviz>=0.11.4
- cachetools>=4.2.1
Expand Down
2 changes: 1 addition & 1 deletion conda-envs/environment-test-py38.yml
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ channels:
- conda-forge
- defaults
dependencies:
- aeppl==0.0.15
- aeppl>=0.0.17
- aesara>=2.2.6
- arviz>=0.11.4
- cachetools>=4.2.1
Expand Down
2 changes: 1 addition & 1 deletion conda-envs/environment-test-py39.yml
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ channels:
- conda-forge
- defaults
dependencies:
- aeppl=0.0.15
- aeppl>=0.0.17
- aesara>=2.2.6
- arviz>=0.11.4
- cachetools
Expand Down
2 changes: 1 addition & 1 deletion conda-envs/windows-environment-dev-py38.yml
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ channels:
- defaults
dependencies:
# base dependencies (see install guide for Windows)
- aeppl=0.0.15
- aeppl>=0.0.17
- aesara>=2.2.6
- arviz>=0.11.4
- cachetools>=4.2.1
Expand Down
2 changes: 1 addition & 1 deletion conda-envs/windows-environment-test-py38.yml
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ channels:
- defaults
dependencies:
# base dependencies (see install guide for Windows)
- aeppl=0.0.15
- aeppl>=0.0.17
- aesara>=2.2.6
- arviz>=0.11.2
- cachetools
Expand Down
12 changes: 0 additions & 12 deletions pymc/tests/sampler_fixtures.py
Original file line number Diff line number Diff line change
Expand Up @@ -11,9 +11,6 @@
# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
# See the License for the specific language governing permissions and
# limitations under the License.
import sys

import aesara
import aesara.tensor as at
import arviz as az
import numpy as np
Expand Down Expand Up @@ -41,15 +38,6 @@ def test_var(self):
samples = self.samples[varname]
npt.assert_allclose(expected, samples.var(0), self.rtol, self.atol)

IS_LINUX = sys.platform == "linux"
IS_FLOAT32 = aesara.config.floatX == "float32"
from pymc.tests.test_posteriors import TestSliceUniform

if IS_LINUX and IS_FLOAT32 and isinstance(self, TestSliceUniform):
raise AssertionError(
"Temporarily fail this test for specific subsytems. See: https://github.com/pymc-devs/pymc/pull/4887#issuecomment-946506545"
)


class KnownCDF:
ks_thin = 5
Expand Down
10 changes: 0 additions & 10 deletions pymc/tests/test_posteriors.py
Original file line number Diff line number Diff line change
Expand Up @@ -12,16 +12,10 @@
# See the License for the specific language governing permissions and
# limitations under the License.

import sys

import aesara
import pytest

from pymc.tests import sampler_fixtures as sf

IS_LINUX = sys.platform == "linux"
IS_FLOAT32 = aesara.config.floatX == "float32"


class TestNUTSUniform(sf.NutsFixture, sf.UniformFixture):
n_samples = 10000
Expand All @@ -43,10 +37,6 @@ class TestMetropolisUniform(sf.MetropolisFixture, sf.UniformFixture):
atol = 0.05


@pytest.mark.xfail(
condition=IS_FLOAT32 and IS_LINUX,
reason="Test fails on linux float32 systems. See https://github.com/pymc-devs/pymc/issues/5088",
)
class TestSliceUniform(sf.SliceFixture, sf.UniformFixture):
n_samples = 10000
tune = 1000
Expand Down
12 changes: 2 additions & 10 deletions pymc/tests/test_sampling.py
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,6 @@
# See the License for the specific language governing permissions and
# limitations under the License.

import sys
import unittest.mock as mock

from contextlib import ExitStack as does_not_raise
Expand All @@ -39,9 +38,6 @@
from pymc.tests.helpers import SeededTest
from pymc.tests.models import simple_init

IS_LINUX = sys.platform == "linux"
IS_FLOAT32 = aesara.config.floatX == "float32"


class TestInitNuts(SeededTest):
def setup_method(self):
Expand Down Expand Up @@ -705,20 +701,16 @@ def test_model_shared_variable(self):
assert post_pred["obs"].shape == (samples, 3)
npt.assert_allclose(post_pred["p"], expected_p)

@pytest.mark.xfail(
condition=IS_FLOAT32 and IS_LINUX,
reason="Test fails on linux float32 systems. See https://github.com/pymc-devs/pymc/issues/5088",
)
def test_deterministic_of_observed(self):
rng = np.random.RandomState(8442)

meas_in_1 = pm.aesaraf.floatX(2 + 4 * rng.randn(10))
meas_in_2 = pm.aesaraf.floatX(5 + 4 * rng.randn(10))
nchains = 2
with pm.Model(rng_seeder=rng) as model:
mu_in_1 = pm.Normal("mu_in_1", 0, 1)
mu_in_1 = pm.Normal("mu_in_1", 0, 2)
sigma_in_1 = pm.HalfNormal("sd_in_1", 1)
mu_in_2 = pm.Normal("mu_in_2", 0, 1)
mu_in_2 = pm.Normal("mu_in_2", 0, 2)
sigma_in_2 = pm.HalfNormal("sd__in_2", 1)

in_1 = pm.Normal("in_1", mu_in_1, sigma_in_1, observed=meas_in_1)
Expand Down
4 changes: 3 additions & 1 deletion pymc/tests/test_transforms.py
Original file line number Diff line number Diff line change
Expand Up @@ -221,7 +221,9 @@ def transform_params(z=a, y=b):
close_to_logical(vals < b, True, tol)


@pytest.mark.xfail(reason="This test produces infinite values using aeppl")
@pytest.mark.skipif(
aesara.config.floatX == "float32", reason="Test is designed for 64bit precision"
)
def test_interval_near_boundary():
lb = -1.0
ub = 1e-7
Expand Down
2 changes: 1 addition & 1 deletion requirements-dev.txt
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
# This file is auto-generated by scripts/generate_pip_deps_from_conda.py, do not modify.
# See that file for comments about the need/usage of each dependency.

aeppl==0.0.15
aeppl>=0.0.17
aesara>=2.2.6
arviz>=0.11.4
cachetools>=4.2.1
Expand Down
2 changes: 1 addition & 1 deletion requirements.txt
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
aeppl==0.0.15
aeppl>=0.0.17
aesara>=2.2.6
arviz>=0.11.4
cachetools>=4.2.1
Expand Down