-
-
Notifications
You must be signed in to change notification settings - Fork 2.1k
Unpin aeppl version #5203
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Unpin aeppl version #5203
Conversation
Codecov Report
@@ Coverage Diff @@
## main #5203 +/- ##
==========================================
- Coverage 78.13% 75.14% -2.99%
==========================================
Files 88 88
Lines 14181 14174 -7
==========================================
- Hits 11080 10651 -429
- Misses 3101 3523 +422
|
|
This test was failing due to the logp assertions introduced by aeppl (see aesara-devs/aeppl#84), which combined with the strongly informative prior away from the likelihood led to underflow of sigma to 0, when using float32, and a subsequent AssertionError. Since this test is only concerned with the accuracy of the deterministic I have simply made the prior less strict.
30cc813
to
4a9f3a4
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like the issue was related to tags
and has been fixed already.
Closes #5191
The new version also fixes some test regressions in #5088