Skip to content

Unpin aeppl version #5203

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Nov 21, 2021
Merged

Unpin aeppl version #5203

merged 3 commits into from
Nov 21, 2021

Conversation

ricardoV94
Copy link
Member

@ricardoV94 ricardoV94 commented Nov 18, 2021

Closes #5191

The new version also fixes some test regressions in #5088

@codecov
Copy link

codecov bot commented Nov 18, 2021

Codecov Report

Merging #5203 (30cc813) into main (c22859d) will decrease coverage by 2.98%.
The diff coverage is n/a.

❗ Current head 30cc813 differs from pull request most recent head 4a9f3a4. Consider uploading reports for the commit 4a9f3a4 to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##             main    #5203      +/-   ##
==========================================
- Coverage   78.13%   75.14%   -2.99%     
==========================================
  Files          88       88              
  Lines       14181    14174       -7     
==========================================
- Hits        11080    10651     -429     
- Misses       3101     3523     +422     
Impacted Files Coverage Δ
pymc/tests/sampler_fixtures.py 90.76% <ø> (-0.48%) ⬇️
pymc/variational/updates.py 11.33% <0.00%> (-76.36%) ⬇️
pymc/plots/posteriorplot.py 32.00% <0.00%> (-64.00%) ⬇️
pymc/distributions/transforms.py 44.82% <0.00%> (-47.13%) ⬇️
pymc/data.py 44.44% <0.00%> (-35.12%) ⬇️
pymc/distributions/dist_math.py 59.35% <0.00%> (-28.35%) ⬇️
pymc/tests/conftest.py 66.66% <0.00%> (-23.81%) ⬇️
pymc/distributions/logprob.py 71.90% <0.00%> (-23.15%) ⬇️
pymc/tests/checks.py 80.00% <0.00%> (-20.00%) ⬇️
pymc/backends/ndarray.py 79.64% <0.00%> (-9.74%) ⬇️
... and 4 more

@ricardoV94
Copy link
Member Author

ricardoV94 commented Nov 18, 2021

Toggled as a draft while testing xfails that are passing locally but not failing here on Github with the strict-xfail. It was a case of global seeding differing between local testing and when running the whole suite.

This test was failing due to the logp assertions introduced by aeppl (see aesara-devs/aeppl#84), which combined with the strongly informative prior away from the likelihood led to underflow of sigma to 0, when using float32, and a subsequent AssertionError. Since this test is only concerned with the accuracy of the deterministic I have simply made the prior less strict.
@ricardoV94 ricardoV94 marked this pull request as ready for review November 18, 2021 14:17
@ricardoV94 ricardoV94 requested a review from kc611 November 18, 2021 16:59
Copy link
Contributor

@kc611 kc611 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like the issue was related to tags and has been fixed already.

@ricardoV94 ricardoV94 merged commit d74537c into pymc-devs:main Nov 21, 2021
@ricardoV94 ricardoV94 deleted the unpin_aeppl branch January 31, 2022 09:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Test suite failing in latest version of aeppl
2 participants