Skip to content

Upload to codecov only once all_tests are run #6660

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Tracked by #7053
ricardoV94 opened this issue Apr 8, 2023 · 2 comments · Fixed by #7208
Closed
Tracked by #7053

Upload to codecov only once all_tests are run #6660

ricardoV94 opened this issue Apr 8, 2023 · 2 comments · Fixed by #7208

Comments

@ricardoV94
Copy link
Member

ricardoV94 commented Apr 8, 2023

Description

Following #6654 we can now wait until all tests have run before uploading the coverage report to codecov.

This will avoid the premature bot message saying coverage has dropped that happens all the time as the initial partial coverage files are uploaded by each individual job.

PyTensor can probably be used as a template: https://github.com/pymc-devs/pytensor/blob/98de246293855def134b86b5af6599e74a44835b/.github/workflows/test.yml#L235-L262

@michaelraczycki
Copy link
Contributor

I'd like to work on that

@ricardoV94
Copy link
Member Author

ricardoV94 commented Jul 12, 2023

Hopefully this will also fix this strange behavior noted by @bwengals #6801 (review)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants