Skip to content

Codecov reintroduce after_n_builds #7208

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 22, 2024
Merged

Conversation

ricardoV94
Copy link
Member

@ricardoV94 ricardoV94 commented Mar 22, 2024

Description

Related Issue

Checklist

Type of change

  • New feature / enhancement
  • Bug fix
  • Documentation
  • Maintenance
  • Other (please specify):

@ricardoV94 ricardoV94 added maintenance Github CI/CD no releasenotes Skipped in automatic release notes generation labels Mar 22, 2024
@ricardoV94
Copy link
Member Author

@ricardoV94
Copy link
Member Author

ricardoV94 commented Mar 22, 2024

Well codecov got shy now

@ricardoV94
Copy link
Member Author

ricardoV94 commented Mar 22, 2024

One of the jabs failed to upload the coverage so we only have 14/15

Copy link

codecov bot commented Mar 22, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.29%. Comparing base (aa679f3) to head (9532371).
Report is 10 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #7208   +/-   ##
=======================================
  Coverage   92.29%   92.29%           
=======================================
  Files         100      100           
  Lines       16875    16875           
=======================================
  Hits        15575    15575           
  Misses       1300     1300           

@ricardoV94
Copy link
Member Author

Here it is! This should be much less confusing for new contributors. Before it would start displaying a drop in coverage / failing test as the first runs get uploaded

@ricardoV94 ricardoV94 requested a review from maresb March 22, 2024 11:40
@ricardoV94 ricardoV94 merged commit a033261 into pymc-devs:main Mar 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Github CI/CD maintenance no releasenotes Skipped in automatic release notes generation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Upload to codecov only once all_tests are run
2 participants