Skip to content

Use margin instead of padding to offset "On this page" #580

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 27, 2022
Merged

Use margin instead of padding to offset "On this page" #580

merged 1 commit into from
Jan 27, 2022

Conversation

pradyunsg
Copy link
Contributor

This makes the border extend much less further, making the aside look
much cleaner.

@pradyunsg
Use margin instead of padding to offset "On this page"
76a9434 
This makes the border extend much less further, making the aside look
much cleaner.
@pradyunsg
Copy link
Contributor Author

main
Screenshot 2022-01-26 at 21 53 12

This PR
Screenshot 2022-01-26 at 21 55 34

This PR + #578 + #579
Screenshot 2022-01-26 at 21 53 34

@pradyunsg pradyunsg marked this pull request as ready for review January 26, 2022 21:56
choldgraf
choldgraf approved these changes Jan 26, 2022
View reviewed changes
Copy link
Collaborator

@choldgraf choldgraf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 from me, I like how the border lines up more closely with the content part of this block 👍

damianavila
damianavila approved these changes Jan 27, 2022
View reviewed changes
Copy link
Collaborator

@damianavila damianavila left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice improvement! And I really like the look after the combination of the 3 PRs.

damianavila
damianavila approved these changes Jan 27, 2022
View reviewed changes
Copy link
Collaborator

@damianavila damianavila left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice improvement! And I really like the look after the combination of the 3 PRs.

Duplicated comment because Github failed when I submitted the review.

@damianavila damianavila merged commit a2497c6 into pydata:master Jan 27, 2022
@pradyunsg pradyunsg deleted the patch-3 branch January 27, 2022 13:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@damianavila damianavila damianavila approved these changes

@choldgraf choldgraf choldgraf approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@pradyunsg @damianavila @choldgraf