Skip to content

Remove the 20px offset below the topbar #579

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jan 27, 2022
Merged

Remove the 20px offset below the topbar #579

merged 3 commits into from
Jan 27, 2022

Conversation

pradyunsg
Copy link
Contributor

@pradyunsg pradyunsg commented Jan 26, 2022 •
edited
Loading

Screenshot 2022-01-26 at 21 34 22

Screenshot 2022-01-26 at 21 34 28

Screenshots, for A/B comparisions. First is this PR.

@pradyunsg pradyunsg changed the title Remove the 20px offset from below the sidebar Remove the 20px offset from below the topbar Jan 26, 2022
@pradyunsg pradyunsg changed the title Remove the 20px offset from below the topbar Remove the 20px offset below the topbar Jan 26, 2022
@pradyunsg pradyunsg marked this pull request as ready for review January 26, 2022 21:35
@pradyunsg
Copy link
Contributor Author

It probably isn't super obvious from the screenshots, but everything on the page is like, 20px higher.

choldgraf
choldgraf approved these changes Jan 26, 2022
View reviewed changes
Copy link
Collaborator

@choldgraf choldgraf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems reasonable to me - I think it looks cleaner to have the sections snap together rather than leaving whitespace in between. Maybe those 20px gaps are historical and not needed anymore? Either way I'm +1

@pradyunsg pradyunsg mentioned this pull request Jan 26, 2022
Merged
damianavila
damianavila approved these changes Jan 27, 2022
View reviewed changes
Copy link
Collaborator

@damianavila damianavila left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Feel more natural to me as well, LGTM.

@damianavila damianavila merged commit 370fa47 into pydata:master Jan 27, 2022
@jorisvandenbossche
Copy link
Member

Maybe those 20px gaps are historical and not needed anymore?

The original calculation with +20px was added in #286
Now I also don't remember why it was needed there (this doesn't change that you can tweak the header-height itself), and I agree that it looks better after this change :)

Thanks @pradyunsg !

@pradyunsg pradyunsg deleted the patch-2 branch January 27, 2022 14:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@damianavila damianavila damianavila approved these changes

@choldgraf choldgraf choldgraf approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@pradyunsg @jorisvandenbossche @damianavila @choldgraf