Skip to content

Fix regression with 'None' inserted in html by google analytics script #404

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 26, 2021
Merged

Fix regression with 'None' inserted in html by google analytics script #404

merged 1 commit into from
Apr 26, 2021

Conversation

jorisvandenbossche
Copy link
Member

@jorisvandenbossche jorisvandenbossche commented Apr 26, 2021 •
edited
Loading

Closes #403

@jorisvandenbossche
Copy link
Member Author

The preview shows this is fixed.
We can later think about whether to better test for this, but for now going to merge this and do a quick bugfix release.

@jorisvandenbossche jorisvandenbossche merged commit 6d316bb into pydata:master Apr 26, 2021
@jorisvandenbossche jorisvandenbossche deleted the fix-regression-none branch April 26, 2021 19:04
@jorisvandenbossche jorisvandenbossche mentioned this pull request Apr 26, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Regression in pydata-sphinx-theme 0.6.2: None added at the bottom left
1 participant
@jorisvandenbossche