Regression in pydata-sphinx-theme 0.6.2: None added at the bottom left

[lesteve]

I noticed in a JupyterBook context and confirmed it goes away with reverting to 0.6.1.

You actually seem to have the same problem in your doc (so probably not JupyterBook-related):

I give you that this is quite hard to spot, who looks at these tiny written things there (e.g. copyright notice) 😉?

[choldgraf]

Ah I wonder if it is the google analytics PR. Here's the Python code:

https://github.com/pydata/pydata-sphinx-theme/blob/master/pydata_sphinx_theme/__init__.py#L259

and inserted here

pydata-sphinx-theme/pydata_sphinx_theme/layout.html

Line 108 in 77a6635

{{ generate_google_analytics_script(id=theme_google_analytics_id) }}

If the function returns nothing, perhaps it is showing up as None in the template. We should instead make it return '' if id is not defined. Just a hunch!

[jorisvandenbossche]

Whoops, thanks for the catch!

[drammock]

Based on where it shows up, I suspect maybe generate_google_analytics_script is returning None and that's getting printed?

[drammock]

hahaha @choldgraf you were a few seconds quicker than me!

[jorisvandenbossche]

Quickly pushed a fix with @choldgraf's suggestion, and did a new release (https://github.com/pydata/pydata-sphinx-theme/releases/tag/v0.6.3).

Closed by #404

[lesteve]

Great thanks a lot!

@jorisvandenbossche as you may have guessed, this was noticed in the context of the scikit-learn MOOC. On top of being in the teaser, you are directly contributing to the MOOC 😉!

Obviously the whole Python ecosystem is contributing to the MOOC but that's another longer story 😉.

[jorisvandenbossche]

Happy to have contributed in those various ways! 😉