Skip to content

Implement pvwatts_multi methods for PVSystem and ModelChain #1132

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 9 commits into from
Jan 20, 2021
Merged

Implement pvwatts_multi methods for PVSystem and ModelChain #1132

merged 9 commits into from
Jan 20, 2021
+116 −43

Conversation

cwhanse
Copy link
Member

@cwhanse cwhanse commented Jan 18, 2021 •
edited
Loading

  • Closes Integrate inverter.pvwatts_multi into PVSystem and ModelChain #1117
  • I am familiar with the contributing guidelines
  • Tests added
  • Updates entries to docs/sphinx/source/api.rst for API changes.
  • Adds description and name entries in the appropriate "what's new" file in docs/sphinx/source/whatsnew for all changes. Includes link to the GitHub Issue with :issue:`num` or this Pull Request with :pull:`num`. Includes contributor name and/or GitHub username (link with :ghuser:`user`).
  • New code is fully documented. Includes numpydoc compliant docstrings, examples, and comments where necessary.
  • Pull request is nearly complete and ready for detailed review.
  • Maintainer: Appropriate GitHub Labels and Milestone are assigned to the Pull Request and linked Issue.

Also converts two functions defining pvwatts systems for PVSystem method tests to fixtures.

@cwhanse cwhanse added this to the 0.9.0 milestone Jan 19, 2021
wholmgren
wholmgren approved these changes Jan 19, 2021
View reviewed changes
Copy link
Member

@wholmgren wholmgren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @cwhanse. I plan to merge tomorrow unless I hear otherwise.

@wholmgren wholmgren merged commit ba4a199 into pvlib:master Jan 20, 2021
@HannanSolo HannanSolo mentioned this pull request Mar 1, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wholmgren wholmgren wholmgren approved these changes

Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
0.9.0
Development

Successfully merging this pull request may close these issues.

Integrate inverter.pvwatts_multi into PVSystem and ModelChain
2 participants
@cwhanse @wholmgren