Skip to content

Conversation

@doolse
Copy link
Contributor

@doolse doolse commented Jun 13, 2018

Still waiting for joncfoo/purescript-parsing#update-for-0.12.0 to be merged in though

Didn't attempt to change the anything to use CodePoint instead of Char or do anything unsafeDecoderURIComponent

@doolse doolse changed the title Fix usages of NonEmptyStrings and decoderURIComponent Changes for 0.12.0 Jun 13, 2018
@vyorkin
Copy link

vyorkin commented Jun 17, 2018

The build is failing here https://github.com/shinnn/install-purescript/blob/master/index.js#L146, I see that we're using node v6.0 on travis CI, if I understand correctly object spread is supported only since nodejs v8.6.0 https://node.green/#ES2018-features-object-rest-spread-properties-object-spread-properties. I'm not sure about this, but you could try to update a version of nodejs in the travis CI config file and run the build again.

P.S.: I need this package too, migrating to 0.12.0 :)

@vyorkin
Copy link

vyorkin commented Jun 17, 2018

btw it makes sense to remove the import of Monoid in Path.purs because it has been moved into the Prelude https://github.com/purescript/purescript-prelude/releases/tag/v4.0.0

@nsaunders
Copy link
Member

For what it's worth, I had the object spread issue that @vyorkin mentioned in paf31/purescript-quickserve#8, and upgrading to Node 9 solved it. It definitely looks to me like the same thing is happening here.

Aside from that, I just want to add that I too am eagerly awaiting upgrading a dependent library, so I would love to know if there is anything I can do to help out here... :-)

test/Main.purs Outdated
main = run [consoleReporter] do
Scheme.spec
UserInfo.spec
UserInfo.spec
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

space

@i-am-the-slime
Copy link

Any chance this might get merged despite the odd extraneous space?

@garyb
Copy link
Member

garyb commented Jun 29, 2018

Thanks! Sorry about the delay, I pushed a few more minor changes too.

@garyb garyb merged commit 428d45d into purescript-contrib:master Jun 29, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

6 participants