-
Notifications
You must be signed in to change notification settings - Fork 23
Changes for 0.12.0 #45
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
The build is failing here https://github.com/shinnn/install-purescript/blob/master/index.js#L146, I see that we're using node v6.0 on travis CI, if I understand correctly object spread is supported only since nodejs v8.6.0 https://node.green/#ES2018-features-object-rest-spread-properties-object-spread-properties. I'm not sure about this, but you could try to update a version of nodejs in the travis CI config file and run the build again. P.S.: I need this package too, migrating to 0.12.0 :) |
|
btw it makes sense to remove the import of |
|
For what it's worth, I had the object spread issue that @vyorkin mentioned in paf31/purescript-quickserve#8, and upgrading to Node 9 solved it. It definitely looks to me like the same thing is happening here. Aside from that, I just want to add that I too am eagerly awaiting upgrading a dependent library, so I would love to know if there is anything I can do to help out here... :-) |
test/Main.purs
Outdated
| main = run [consoleReporter] do | ||
| Scheme.spec | ||
| UserInfo.spec | ||
| UserInfo.spec |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
space
|
Any chance this might get merged despite the odd extraneous space? |
|
Thanks! Sorry about the delay, I pushed a few more minor changes too. |
Still waiting for joncfoo/purescript-parsing#update-for-0.12.0 to be merged in though
Didn't attempt to change the anything to use
CodePointinstead ofCharor do anythingunsafeDecoderURIComponent