Skip to content
This repository was archived by the owner on Feb 2, 2021. It is now read-only.

Conversation

@nsaunders
Copy link
Contributor

  • Updated Bower dependencies (upgrades and addition of purescript-console)
  • Updated NPM dependencies (upgrades)
  • Updated imports
  • Removed effect rows
sphx01w01:purescript-quickserve nick$ npm run build

> @ build /Users/nick/Projects/purescript-quickserve
> pulp build -- --censor-lib --strict

* Building project in /Users/nick/Projects/purescript-quickserve
           Src   Lib   All
Warnings   0     0     0  
Errors     0     0     0  
* Build successful.
sphx01w01:purescript-quickserve nick$ curl http://localhost:3000/hello
Hello, World!sphx01w01:purescript-quiccurl http://localhost:3000/echo1 -XPOST -d '{"message": "test"}'
{"message":"test"}sphx01w01:purescriptcurl http://localhost:3000/echo2/test
testsphx01w01:purescript-quickserve nick$ 
sphx01w01:purescript-quickserve nick$ pulp test
* Building project in /Users/nick/Projects/purescript-quickserve
* Build successful.
* Running tests...
Listening on port 3000
GET "/hello"
POST "/echo1"
test
GET "/echo2/test"

@nsaunders
Copy link
Contributor Author

nsaunders commented Jun 17, 2018

I've upgraded the Node version from 6 to 9 in the .travis.yml file due to the install-purescript-cli package using the spread operator (apparently not available in version 6).

That just leaves this UnusedTypeVar warning that doesn't entirely make sense to me since no e variable is used here... @paf31 maybe you can shed some light on this?

[1/1 UnusedTypeVar] src/QuickServe.purs:198:1
       v
  198  instance servableRequestBody
  199      :: (IsRequest request, Servable service)
  200      => Servable (RequestBody request -> service) where
                                                      ^
  
  Type variable e is ambiguous, since it is unused in the polymorphic type which introduces it.

@nsaunders
Copy link
Contributor Author

Thanks @Thimoteus for helping me spot that unused type variable!

Copy link
Owner

@paf31 paf31 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, looks great!

@paf31 paf31 merged commit ae61a29 into paf31:master Jun 18, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants