Skip to content

small fix to delete_values_spec.rb and README.markdown #172

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 28, 2013
Merged

small fix to delete_values_spec.rb and README.markdown #172

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions README.markdown
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -215,6 +215,8 @@ Deletes all instances of a given value from a hash.
Would return: {'a'=>'A','c'=>'C','B'=>'D'}


- *Type*: rvalue

delete_undef_values
-------------------
Deletes all instances of the undef value from an array or hash.
Expand Down
2 changes: 1 addition & 1 deletion spec/unit/puppet/parser/functions/delete_values_spec.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@
end

it "should raise a ParseError if there are greater than 2 arguments" do
lambda { scope.function_delete([[], 'foo', 'bar']) }.should( raise_error(Puppet::ParseError))
lambda { scope.function_delete_values([[], 'foo', 'bar']) }.should( raise_error(Puppet::ParseError))
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Errors like this can creep in if there's no expectation of the errror message itself. I'll merge this in, but future tests should add expectations on both that an error was raised, and that the right error message was raised as well.

end

it "should raise a TypeError if the argument is not a hash" do
Expand Down