small fix to delete_values_spec.rb and README.markdown #172
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -13,7 +13,7 @@ | |||
| end | |||
|
|
|||
| it "should raise a ParseError if there are greater than 2 arguments" do | |||
| lambda { scope.function_delete([[], 'foo', 'bar']) }.should( raise_error(Puppet::ParseError)) | |||
| lambda { scope.function_delete_values([[], 'foo', 'bar']) }.should( raise_error(Puppet::ParseError)) | |||
There was a problem hiding this comment.
Errors like this can creep in if there's no expectation of the errror message itself. I'll merge this in, but future tests should add expectations on both that an error was raised, and that the right error message was raised as well.
adrienthebo
added a commit
that referenced
this pull request
Aug 28, 2013
small fix to delete_values_spec.rb and README.markdown
|
summary: merged into master in 6dd6d06; thanks for the contribution! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just caught it.