(MODULES-5187)(MODULES-52080) mysnc puppet 5 and ruby 2.4 #229
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
glennsarti
force-pushed
the
msync_modules5187
branch
from
f075aea to
f8aac54
Compare
glennsarti
changed the title
|
Many of the tests are expecting puppet4 error output. Need to update to Puppet 5 |
As part of PUP-5659 relationship validation in the catalog now errors instead of warning for missing required relationships. Previously the spec tests were passing as Puppet 4.x would ignore the required resource e.g. the sqlserver::login::permissions resource required a sql::config resource in the catalog. However our test fixtures were not creating that but Puppet didn't care. Now that Puppet des validate these relationships, the specs were failing. This commit adds the required resources into the test fixtures.
glennsarti
force-pushed
the
msync_modules5187
branch
from
f8aac54 to
69ce234
Compare
glennsarti
changed the title
glennsarti
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.