Skip to content

(MODULES-5187)(MODULES-52080) mysnc puppet 5 and ruby 2.4 #229

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 12, 2017

Conversation

eputnam
Copy link
Contributor

@eputnam eputnam commented Jul 6, 2017

No description provided.

@glennsarti
Copy link
Contributor

@eputnam Needs a rebase. Fixes for puppet 5 were merged in from 4a090f2

@glennsarti glennsarti changed the title (MODULES-5187) mysnc puppet 5 and ruby 2.4 {WIP}(MODULES-5187) mysnc puppet 5 and ruby 2.4 Jul 12, 2017
@glennsarti
Copy link
Contributor

Many of the tests are expecting puppet4 error output. Need to update to Puppet 5

As part of PUP-5659 relationship validation in the catalog now errors instead of
warning for missing required relationships.  Previously the spec tests were
passing as Puppet 4.x would ignore the required resource e.g. the
sqlserver::login::permissions resource required a sql::config resource in the
catalog.  However our test fixtures were not creating that but Puppet didn't
care.  Now that Puppet des validate these relationships, the specs were failing.
This commit adds the required resources into the test fixtures.
@glennsarti glennsarti changed the title {WIP}(MODULES-5187) mysnc puppet 5 and ruby 2.4 {WIP}(MODULES-5187)(MODULES-52080) mysnc puppet 5 and ruby 2.4 Jul 12, 2017
@glennsarti glennsarti changed the title {WIP}(MODULES-5187)(MODULES-52080) mysnc puppet 5 and ruby 2.4 (MODULES-5187)(MODULES-52080) mysnc puppet 5 and ruby 2.4 Jul 12, 2017
@eputnam eputnam merged commit 842add1 into master Jul 12, 2017
@glennsarti glennsarti deleted the msync_modules5187 branch July 12, 2017 19:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants