(MODULES-5208) Fix spec tests for Puppet 5

As part of PUP-5659 relationship validation in the catalog now errors instead of
warning for missing required relationships.  Previously the spec tests were
passing as Puppet 4.x would ignore the required resource e.g. the
sqlserver::login::permissions resource required a sql::config resource in the
catalog.  However our test fixtures were not creating that but Puppet didn't
care.  Now that Puppet des validate these relationships, the specs were failing.
This commit adds the required resources into the test fixtures.

Author: glennsarti

spec/defines/database_spec.rb

@@ -9,14 +9,14 @@
         :db_name => 'myTestDb',
         :instance => 'MSSQLSERVER',
     } }
-  end
-
-  describe 'Minimal Params' do
     let(:pre_condition) { <<-EOF
       define sqlserver::config{}
       sqlserver::config {'MSSQLSERVER': }
     EOF
     }
+  end
+
+  describe 'Minimal Params' do
     it_behaves_like 'compile'
   end
 

spec/defines/login/permissions_spec.rb

@@ -3,6 +3,11 @@
 
 describe 'sqlserver::login::permissions' do
   let(:facts) { {:osfamily => 'windows'} }
+  let(:pre_condition) { <<-EOF
+    define sqlserver::config{}
+    sqlserver::config {'MSSQLSERVER': }
+  EOF
+  }
   context 'validation errors' do
     include_context 'manifests' do
       let(:title) { 'myTitle' }

spec/defines/login_spec.rb

@@ -9,6 +9,11 @@
       :login => 'myTitle',
       :instance => 'MSSQLSERVER',
     } }
+    let(:pre_condition) { <<-EOF
+      define sqlserver::config{}
+      sqlserver::config {'MSSQLSERVER': }
+    EOF
+    }
   end
 
   describe 'Minimal Params' do

spec/defines/sp_configure_spec.rb

@@ -9,6 +9,11 @@
         :config_name => 'filestream access level',
         :value => 1,
     } }
+    let(:pre_condition) { <<-EOF
+      define sqlserver::config{}
+      sqlserver::config {'MSSQLSERVER': }
+    EOF
+    }
   end
   describe 'basic usage' do
     let(:should_contain_command) { [

spec/defines/user/permissions_spec.rb

@@ -3,6 +3,12 @@
 
 describe 'sqlserver::user::permissions' do
   let(:facts) { {:osfamily => 'windows'} }
+  let(:pre_condition) { <<-EOF
+    define sqlserver::config{}
+    sqlserver::config {'MSSQLSERVER': }
+  EOF
+  }
+
   context 'validation errors' do
     include_context 'manifests' do
       let(:title) { 'myTitle' }

spec/defines/user_spec.rb

@@ -6,6 +6,11 @@
     let(:title) { 'loggingUser' }
     let(:sqlserver_tsql_title) { 'user-MSSQLSERVER-myDatabase-loggingUser' }
     let(:params) { {:user => 'loggingUser', :database => 'myDatabase'} }
+    let(:pre_condition) { <<-EOF
+      define sqlserver::config{}
+      sqlserver::config {'MSSQLSERVER': }
+    EOF
+    }
   end
 
   describe 'should fail when password above 128 characters' do