Skip to content

(MODULES-5092) Failures during .Net 3 installation should be obvious #216

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 16, 2017
Merged

(MODULES-5092) Failures during .Net 3 installation should be obvious #216

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4d6d694
(maint) Declare ALL_SQL_VERSIONS once
glennsarti Jun 12, 2017
d40db77
(MODULES-5092) Failures during .Net 3 installation should be obvious
glennsarti Jun 13, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion lib/puppet/provider/sqlserver.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -59,7 +59,7 @@ def self.run_install_dot_net(source_location = nil)
Else
{
Write-Host "Installing .Net Framework 3.5, do not close this prompt..."
DISM /Online /Enable-Feature /FeatureName:NetFx3 /All /NoRestart /Quiet /LimitAccess #{ "/Source:\"#{source_location}\"" unless source_location.nil? } | Out-Null
$InstallResult = DISM /Online /Enable-Feature /FeatureName:NetFx3 /All /NoRestart /Quiet /LimitAccess #{ "/Source:\"#{source_location}\"" unless source_location.nil? }
$Result = Dism /online /Get-featureinfo /featurename:NetFx3
If($Result -contains "State : Enabled")
{
Expand All @@ -68,6 +68,10 @@ def self.run_install_dot_net(source_location = nil)
Else
{
Write-Host "Failed to install Install .Net Framework 3.5#{ ", please make sure the windows_feature_source is correct" unless source_location.nil?}."
Write-Host "DISM Install Result"
Write-Host "-----------"
Write-Host ($InstallResult -join "`n")
#exit 1
}
}
DOTNET
Expand Down
2 changes: 1 addition & 1 deletion lib/puppet_x/sqlserver/features.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
SQL_2014 ||= 'SQL_2014'
SQL_2016 ||= 'SQL_2016'

ALL_SQL_VERSIONS = [SQL_2012, SQL_2014, SQL_2016]
ALL_SQL_VERSIONS ||= [SQL_2012, SQL_2014, SQL_2016]

module PuppetX
module Sqlserver
Expand Down