(MODULES-5092) Failures during .Net 3 installation should be obvious #216
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously the module would generate warnings that the ALL_SQL_VERSIONS constant was already defined. This commit changes the assignment so that it only assigns the constant if it does not already exist.
Previously if dot Net 3 experienced an error during installation, no error would be logged and instead the SQL Setup would then fail but not inform Puppet as to why. This commit changes the dot Net 3 installation method to instead log the output from the installation process and fail the puppet run, with log information, if the installation fails.
jpogran
approved these changes
Jun 16, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously if dot Net 3 experienced an error during installation, no error
would be logged and instead the SQL Setup would then fail but not inform Puppet
as to why. This commit changes the dot Net 3 installation method to instead
log the output from the installation process and fail the puppet run, with log
information, if the installation fails.