Add abstract data types to lexer type tokens list #240
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Using Regexp's Extended Mode (the `x` modifier).
This commit adds the missing types from https://www.puppet.com/docs/puppet/8/lang_data_abstract.html
bastelfreak
approved these changes
Mar 7, 2025
bastelfreak
added a commit
to bastelfreak/voxpupuli-puppet-lint-plugins
that referenced
this pull request
Sep 25, 2025
This pulls in three bigger changes in puppet-lint: * Avoid using the manifest lexer on YAML [#239](puppetlabs/puppet-lint#239) (tokenrove) * Add abstract data types to lexer type tokens list [#240](puppetlabs/puppet-lint#240) (kenyon) * Fix Ensure check methods can't modify tokens array and add Ruby 3.4 testing [#233](puppetlabs/puppet-lint#233) (alexjfisher) In a previous PR, voxpupuli#64, we switched to Ruby 3.2 as a minimal Ruby version. The new puppet-lint release did a Ruby version bump. We don't want to end up in a situation where different users have different ruby versions, which leads to different puppet-lint versions, which leads to different linting of your puppet code. Because of that, we cannot allow puppet-lint 4 & 5, but have to pint to 5.1 (5.0 doesn't support Ruby 3.4). All puppet-lint plugins were also updated for puppet-lint 5.1, which also required major releases.
bastelfreak
added a commit
to bastelfreak/voxpupuli-puppet-lint-plugins
that referenced
this pull request
Sep 25, 2025
This pulls in three bigger changes in puppet-lint: * Avoid using the manifest lexer on YAML [#239](puppetlabs/puppet-lint#239) (tokenrove) * Add abstract data types to lexer type tokens list [#240](puppetlabs/puppet-lint#240) (kenyon) * Fix Ensure check methods can't modify tokens array and add Ruby 3.4 testing [#233](puppetlabs/puppet-lint#233) (alexjfisher) In a previous PR, voxpupuli#64, we switched to Ruby 3.2 as a minimal Ruby version. The new puppet-lint release did a Ruby version bump. We don't want to end up in a situation where different users have different ruby versions, which leads to different puppet-lint versions, which leads to different linting of your puppet code. Because of that, we cannot allow puppet-lint 4 & 5, but have to pint to 5.1 (5.0 doesn't support Ruby 3.4). All puppet-lint plugins were also updated for puppet-lint 5.1, which also required major releases.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Same as #216 and #224, these abstract data types were missing from the lexer.