Add Error type to the lexer tokens (and sort them) #216
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
JFYI, the change is untested.. I'm unable to test it right now. |
bastelfreak
reviewed
Aug 22, 2024
| # FIXME: Future breaking change, the following :TYPE tokens conflict with | ||
| # the :TYPE keyword token. | ||
| [:TYPE, %r{\A(Integer|Float|Boolean|Regexp|String|Array|Hash|Resource|Class|Collection|Scalar|Numeric|CatalogEntry|Data|Tuple|Struct|Optional|NotUndef|Variant|Enum|Pattern|Any|Callable|Type|Runtime|Undef|Default|Sensitive)\b}], # rubocop:disable Layout/LineLength | ||
| [:TYPE, %r{\A(Any|Array|Boolean|Callable|CatalogEntry|Class|Collection|Data|Default|Enum|Error|Float|Hash|Integer|NotUndef|Numeric|Optional|Pattern|Regexp|Resource|Runtime|Scalar|Sensitive|String|Struct|Tuple|Type|Undef|Variant)\b}], # rubocop:disable Layout/LineLength |
There was a problem hiding this comment.
I like the sorting by name, but could you please do that in a second commit? That makes it a bit easier to read the diff.
There was a problem hiding this comment.
I split the change to 2 commits. Please enjoy :-D
david22swan
requested changes
Aug 30, 2024
There was a problem hiding this comment.
Hey, if you could add a small unit test for this we would be happy to go ahead and merge.
https://github.com/puppetlabs/puppet-lint/blob/main/spec/unit/puppet-lint/lexer_spec.rb
|
I added some naive test. Not sure if it's good enough. |
This was referenced Mar 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Error type wasn't known to the lexer. That makes puppet-lint to fire
unquoted_string_in_{selector|case}on this type check.Additional Context
Consider this code:
Puppet-lint will raise a warning on the line containing the Error.
Related Issues (if any)
Checklist