Skip to content

(FACT-2872_2) Reimplement linux networking resolver #2219

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
BogdanIrimie merged 3 commits into from
Dec 10, 2020
Merged

(FACT-2872_2) Reimplement linux networking resolver #2219

BogdanIrimie merged 3 commits into from
Dec 10, 2020

Conversation

@Filipovici-Andrei
Copy link
Contributor

@Filipovici-Andrei Filipovici-Andrei commented Dec 9, 2020

No description provided.

@Filipovici-Andrei Filipovici-Andrei force-pushed the FACT-2872_2 branch 7 times, most recently from 81abdf1 to c4f4fef Compare December 10, 2020 11:08
@Filipovici-Andrei
Copy link
Contributor Author

Filipovici-Andrei commented Dec 10, 2020

jenkins please test this on all

@Filipovici-Andrei Filipovici-Andrei force-pushed the FACT-2872_2 branch 5 times, most recently from 59de5f7 to a01ff4a Compare December 10, 2020 13:42
@Filipovici-Andrei
Copy link
Contributor Author

Filipovici-Andrei commented Dec 10, 2020

jenkins please test this on all

@Filipovici-Andrei
Copy link
Contributor Author

Filipovici-Andrei commented Dec 10, 2020

jenkins please test this on all

@Filipovici-Andrei Filipovici-Andrei force-pushed the FACT-2872_2 branch 3 times, most recently from b1c1c4d to acf6f57 Compare December 10, 2020 15:55
@Filipovici-Andrei Filipovici-Andrei changed the title (FACT-2872_2) Reimplement linux networking resolver (FACT-2872) Reimplement linux networking resolver Dec 10, 2020
@Filipovici-Andrei Filipovici-Andrei changed the title (FACT-2872) Reimplement linux networking resolver (FACT-2872_2) Reimplement linux networking resolver Dec 10, 2020
@Filipovici-Andrei Filipovici-Andrei force-pushed the FACT-2872_2 branch 4 times, most recently from 024529e to 4eee481 Compare December 10, 2020 16:21
@BogdanIrimie BogdanIrimie marked this pull request as ready for review December 10, 2020 16:41
@BogdanIrimie BogdanIrimie requested review from a team December 10, 2020 16:41
@BogdanIrimie BogdanIrimie merged commit cc1b91d into puppetlabs:main Dec 10, 2020
@BogdanIrimie BogdanIrimie mentioned this pull request Dec 10, 2020
Closed
@joshcooper
Copy link
Contributor

joshcooper commented Dec 11, 2020

CI failed on all Solarises (Solari?) with this change:

Expected /^(?:(?:25[0-5]|2[0-4][0-9]|[01]?[0-9][0-9]?)\.){3}(?:25[0-5]|2[0-4][0-9]|[01]?[0-9][0-9]?)$/ to match "".

I think it's because previously the networking.dhcp fact was reported correctly in puppet-agent#2b5f4eea0:

$ facter --json "networking.dhcp"
{
  "networking.dhcp": "10.32.22.9"
}

But now using puppet-agent#c5bed133e, it's empty:

$ facter networking --json
    {
      "networking": {
        "dhcp": "",

@Filipovici-Andrei Filipovici-Andrei deleted the FACT-2872_2 branch December 11, 2020 10:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@BogdanIrimie BogdanIrimie BogdanIrimie approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@Filipovici-Andrei @joshcooper @BogdanIrimie