(FACT-2872) Added support for labeled secondary ips and inactive interfaces on linux platforms #2202
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Filipovici-Andrei
force-pushed
the
FACT-2872
branch
2 times, most recently
from
f6b81db to
6b5784b
Compare
Filipovici-Andrei
changed the title
Filipovici-Andrei
force-pushed
the
FACT-2872
branch
15 times, most recently
from
3bab784 to
c4a42a4
Compare
Filipovici-Andrei
force-pushed
the
FACT-2872
branch
from
c4a42a4 to
8544786
Compare
Contributor
Author
|
jenkins please test this on all |
florindragos
changed the title
Contributor
|
jenkins please test this on all |
florindragos
approved these changes
Dec 4, 2020
Contributor
Author
|
jenkins please test this on amazon6-64a |
Contributor
Author
|
jenkins please test this on amazon6-64a |
Filipovici-Andrei
force-pushed
the
FACT-2872
branch
from
60fb850 to
d6554b4
Compare
Contributor
Author
|
jenkins please test this on amazon6-64a |
Filipovici-Andrei
force-pushed
the
FACT-2872
branch
from
d6554b4 to
8bf0dc9
Compare
Contributor
Author
|
jenkins please test this on amazon6-64a |
Filipovici-Andrei
force-pushed
the
FACT-2872
branch
from
8bf0dc9 to
db1586a
Compare
Contributor
Author
|
jenkins please test this on amazon6-64a, amazon7-64a |
Filipovici-Andrei
force-pushed
the
FACT-2872
branch
5 times, most recently
from
ced32f8 to
d270abb
Compare
Contributor
Author
|
jenkins please test this on amazon6-64a |
Filipovici-Andrei
force-pushed
the
FACT-2872
branch
from
d270abb to
ba3e48b
Compare
Contributor
Author
|
jenkins please test this on amazon6-64a, amazon7-64a |
Contributor
|
The resolver was reworked on #2219 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem:
On linux platforms interfaces were extracted using the 'ip -o address'. This didn't output the inactive interfaces.
Secondary IPs, were displayed only in the bindings/bindings6 section of the physical interface and not as a separate interface.
Solution:
Secondary IPs, if they have a label, will also be displayed as a separate interface.
Check for scope6 has been added in the facts/networking acceptance test.
Acceptance test for VLANs has been added.