fix for bug #4943 - Unregister-PnPHubSite throwing Object reference not set to an instance of an object. #4944
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Does the new code find the props to unregister the hub ? Or does the new code throw another exception as it cannot find a hub with empty url ? |
|
The CSOM function GetHubSitesProperties() was returning an entry with the Url being null/empty preventing me to do anything related to unregister any hub site. The updated code adds a small check to handle null/empty url values returned by GetHubSitesProperties. |
|
Thanks @reshmee011, good catch , merged it ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type
Related Issues?
Fixes #4943
What is in this Pull Request ?
A small check to cater for SiteUrl being null or empty
props = hubSitesProperties.Single(h => !string.IsNullOrEmpty(h.SiteUrl) && h.SiteUrl.Equals(Site.Url, StringComparison.OrdinalIgnoreCase));