Skip to content

better handling of colorscale inputs #1485

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 8 commits into from
Mar 14, 2019
Merged

better handling of colorscale inputs #1485

merged 8 commits into from
Mar 14, 2019

Conversation

cpsievert
Copy link
Collaborator

Fixes #1432

@cpsievert cpsievert requested a review from schloerke March 12, 2019 15:58
@schloerke
Copy link
Contributor

@cpsievert The tests seem to be failing

cpsievert
cpsievert commented Mar 12, 2019
View reviewed changes
cpsievert
cpsievert commented Mar 12, 2019
View reviewed changes
cpsievert
cpsievert commented Mar 12, 2019
View reviewed changes
schloerke
schloerke suggested changes Mar 13, 2019
View reviewed changes
Copy link
Contributor

@schloerke schloerke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

add NA test. Next time separate out n1 + n2 = 0

@cpsievert cpsievert merged commit 02c9aa4 into master Mar 14, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
1 more reviewer

@schloerke schloerke schloerke approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@cpsievert @schloerke