Skip to content
This repository was archived by the owner on Jun 4, 2024. It is now read-only.

Page numbers and page navigation improvements #595

Merged
merged 47 commits into from
Oct 4, 2019
Merged

Page numbers and page navigation improvements #595

merged 47 commits into from
Oct 4, 2019

Conversation

shammamah-zz
Copy link
Contributor

@shammamah-zz shammamah-zz commented Sep 20, 2019 •
edited
Loading

Closes #580.
Closes #299.

About

  • Updated appearance of previous/next buttons
  • Added go-to-first and go-to-last buttons
  • Added {current}/{total} page numbers between navigation arrows
  • Added support for user input to directly navigate to a page
  • Moved pagination menu/functionality to separate component

@chriddyp chriddyp temporarily deployed to dash-table-review-pr-595 September 20, 2019 15:14 Inactive
@shammamah-zz shammamah-zz temporarily deployed to dash-table-review-pr-595 September 20, 2019 15:15 Inactive
@shammamah-zz shammamah-zz force-pushed the page-numbers-pagination branch from e343525 to e941cd1 Compare September 20, 2019 15:19
@shammamah-zz shammamah-zz temporarily deployed to dash-table-review-pr-595 September 20, 2019 15:19 Inactive
@shammamah-zz shammamah-zz temporarily deployed to dash-table-review-pr-595 September 20, 2019 15:20 Inactive
@shammamah-zz shammamah-zz changed the title Page numbers pagination Page numbers and page navigation improvements Sep 20, 2019
@shammamah-zz shammamah-zz temporarily deployed to dash-table-review-pr-595 September 20, 2019 15:35 Inactive
@shammamah-zz shammamah-zz temporarily deployed to dash-table-review-pr-595 September 20, 2019 19:05 Inactive
@shammamah-zz shammamah-zz force-pushed the page-numbers-pagination branch from f06c6a9 to c6aa878 Compare September 20, 2019 19:52
@shammamah-zz shammamah-zz temporarily deployed to dash-table-review-pr-595 September 20, 2019 19:52 Inactive
@shammamah-zz shammamah-zz temporarily deployed to dash-table-review-pr-595 September 25, 2019 15:34 Inactive
@shammamah-zz shammamah-zz force-pushed the page-numbers-pagination branch from 9f32021 to 5cf474d Compare September 25, 2019 15:57
@shammamah-zz shammamah-zz temporarily deployed to dash-table-review-pr-595 September 25, 2019 15:57 Inactive
@shammamah-zz shammamah-zz temporarily deployed to dash-table-review-pr-595 September 25, 2019 16:01 Inactive
@shammamah-zz shammamah-zz temporarily deployed to dash-table-review-pr-595 September 25, 2019 18:46 Inactive
Marc-Andre-Rivet and others added 15 commits October 3, 2019 16:23
@Marc-Andre-Rivet
Delete __init__.py
4062fe0
Fix eslint errors.
3891aa5
Make goToPage logic shorter.
6dfa09a
Move button disable logic to paginator.
2787cc9
Add underline to input box.
6ee6256
Improve test for no page_count defined.
449efea
Fix error.
a3e6bf0
@Marc-Andre-Rivet
Update src/dash-table/dash/DataTable.js
ff95d7f 
Co-Authored-By: Marc-André Rivet <[email protected]>
@Marc-Andre-Rivet
Update src/dash-table/components/PageNavigation/index.tsx
5828ff3 
Co-Authored-By: Marc-André Rivet <[email protected]>
Add new wrapper class around table and pagination menu.
398fe88 
Clean up LESS.
Change paginator function names.
2cd3384
Allow for submit on enter.
81323ef
Add test for submitting page number with enter key.
5c5b714
Move loadFirst, loadPrevious, and hasPrevious out of FE/BE.
0ad5ab8 
These functions are exactly the same in both implementations.
Refactor paginator code.
4696a87
@shammamah-zz shammamah-zz force-pushed the page-numbers-pagination branch from 4ccba6e to 4696a87 Compare October 3, 2019 20:24
@shammamah-zz shammamah-zz temporarily deployed to dash-table-review-pr-595 October 3, 2019 20:24 Inactive
@shammamah-zz shammamah-zz temporarily deployed to dash-table-review-pr-595 October 3, 2019 20:25 Inactive
@chriddyp chriddyp temporarily deployed to dash-table-review-pr-595 October 4, 2019 16:43 Inactive
@shammamah-zz shammamah-zz temporarily deployed to dash-table-review-pr-595 October 4, 2019 18:07 Inactive
@shammamah-zz shammamah-zz force-pushed the page-numbers-pagination branch from 49dcf6f to cccf613 Compare October 4, 2019 18:18
Marc-Andre-Rivet
Marc-Andre-Rivet approved these changes Oct 4, 2019
View reviewed changes
Copy link
Contributor

@Marc-Andre-Rivet Marc-Andre-Rivet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💃 Looks good

@shammamah-zz shammamah-zz merged commit 0ed2bea into dev Oct 4, 2019
@shammamah-zz shammamah-zz deleted the page-numbers-pagination branch October 4, 2019 18:51
This was referenced Oct 10, 2019
Closed
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@Marc-Andre-Rivet Marc-Andre-Rivet Marc-Andre-Rivet approved these changes

@alexcjohnson alexcjohnson Awaiting requested review from alexcjohnson alexcjohnson is a code owner

@wbrgss wbrgss Awaiting requested review from wbrgss

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[FEATURE] Enhanced page navigation UI show page numbers for pagination
5 participants
@shammamah-zz @Marc-Andre-Rivet @alexcjohnson @chriddyp @dmt0